Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Supplemental changes of druntime/pull/72 - Issue 1824 - Object not const correct #387

Merged
merged 1 commit into from

3 participants

@9rnsr
Collaborator

http://d.puremagic.com/issues/show_bug.cgi?id=1824
#387
D-Programming-Language/druntime#72
D-Programming-Language/phobos#262

This pull request does not change compiler, but fixes only dmd test suites.

2011/10/15
This change also fix issue 3780, because it requires const equality comparison for member classes.

requires: druntime git://github.com/9rnsr/druntime.git constApply
requires: phobos git://github.com/9rnsr/phobos.git constApply

@yebblies
Collaborator

The pull request autotester currently can only handle a pull request dependencies in the order dmd -> druntime -> phobos, unfortunately. It will work correctly if you put a requires: line for the druntime and phobos pull requests inside this pull request, but will choke with the way it's currently arranged.

@9rnsr
Collaborator

@yebblies
Updated. Is this correct?

And, I want to avoid your autotester running on druntime/pull/72 and phobos/pull/262.
Do you know how to do it?

@yebblies
Collaborator

Great, it should be able to handle it now. It'll be about 18 hours until it shows up on the results page.
If the branch for a druntime or phobos pull request is 'requires:'ed by another pull request, it will be skipped.

@9rnsr
Collaborator

This change now also fix issue 3780, because it requires const equality comparison for member classes.

@yebblies yebblies referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
@yebblies yebblies referenced this pull request from a commit in yebblies/dmd
@yebblies yebblies Reintroduce the fix for issue 3632, without the dependency on fixing …
…issue 1824.

Revert the parts in clone.c that were commented out, so pull #387 can merge cleanly.
f9c21c2
@9rnsr
Collaborator

Rebased, and removed changes for 3780, because it's something wrong.

@WalterBright WalterBright merged commit 271085b into from
@9rnsr 9rnsr referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
@9rnsr 9rnsr referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
@9rnsr 9rnsr referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
@9rnsr 9rnsr referenced this pull request from a commit in 9rnsr/dmd
@9rnsr 9rnsr Revert "Merge pull request #387 from 9rnsr/constApply"
This reverts commit 271085b, reversing
changes made to 782fe63.
25d18e0
@braddr braddr referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
@ghost Unknown referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
@ghost Unknown referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
@ghost Unknown referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
@ghost Unknown referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jul 8, 2012
  1. @9rnsr

    Add const.

    9rnsr authored
This page is out of date. Refresh to see the latest.
View
6 test/runnable/imports/test13a.d
@@ -29,13 +29,13 @@ template TPair(T, U) {
this._left = left;
this._right = right;
}
- public T left() {
+ public const T left() {
return this._left;
}
- public U right() {
+ public const U right() {
return this._right;
}
- override public boolean opEquals(Object obj) {
+ override public const boolean opEquals(const Object obj) {
Pair other = cast(Pair) obj;
if (other !is null) {
return (left() == other.left()) && (right() == other.right());
View
4 test/runnable/opover2.d
@@ -133,7 +133,7 @@ void test4()
class A5
{
- override bool opEquals(Object o)
+ override const bool opEquals(const Object o)
{
printf("A.opEquals!(%p)\n", o);
return 1;
@@ -155,7 +155,7 @@ class A5
class B5 : A5
{
- override bool opEquals(Object o)
+ override const bool opEquals(const Object o)
{
printf("B.opEquals!(%p)\n", o);
return 1;
View
2  test/runnable/test42.d
@@ -3576,7 +3576,7 @@ static assert(is(typeof(S5110.value) == int));
class C5110
{
override:
- string toString() { return ""; }
+ const string toString() { return ""; }
class Nested
{
Something went wrong with that request. Please try again.