Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

bool cleanup #678

Closed
wants to merge 14 commits into from

4 participants

Trass3r Andrei Alexandrescu Walter Bright Rainer Schuetze
Trass3r

more properly use bool type

Trass3r

The last two commits are separate cause those int variables were suspiciously used ( != 1 and ++ operations)
But I think they should be bool.

Trass3r
Trass3r commented May 02, 2012

any issues with the pull request that prevent merging?

Trass3r

Really no clue why it runs out of memory on Windoze: http://d.puremagic.com/test-results/pull.ghtml?runid=183905
It works on my machine.

Andrei Alexandrescu
Owner

I think we should rebase and pull this. It makes it easier for newcomers to the project to understand the code base.

Trass3r

Rebased it. Let's see what the tester says ;)

Walter Bright

It's an awful pervasive chunk to merge at once :-(

Trass3r

Ok, what do you suggest?

Trass3r

btw I think the pure int type shouldn't be used at all.
You never know if it's an actual int32_t, a bool or an enum.

Walter Bright

I suggest more bite sized chunks. Remember, I also have to fold these into D1. Having a thousand lines to do one by one is just awfully tedious.

It's either that, or wait on this until D1 is no longer officially supported.

Trass3r

I see, didn't think of D1.
Just a few weeks remaining.

Andrei Alexandrescu
Owner

ping? will close for now, fwiw i think we should pull this

Andrei Alexandrescu andralex closed this May 12, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.