Fix Issue 13390 - Be explicit about non-empty input and fail early #3001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Thanks! |
kuettler
changed the title
|
Auto-merge toggled on |
MartinNowak
added a commit
that referenced
this pull request
Mar 1, 2015
Fix Issue 13390 - Be explicit about non-empty input and fail early
MartinNowak
added a commit
that referenced
this pull request
Mar 10, 2015
Fix Issue 13390 - Be explicit about non-empty input and fail early
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regression seems that a late crash (in
front, dmd 2.065) became an early crash (in the constructor, dmd 2.066.0). There are several unexciting ways to consider:assertbefore constructionassertin each methodIn this light I guess fail early is the best choice. The old behavior might be considered a bug. Then this fix just defines valid input.