Build phobos package at a time #3379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forgot to build and include the extra files. This has low impact of performance as follows: OSX: 4.01s, 617668608 |
CyberShadow
added a commit
that referenced
this pull request
Jun 6, 2015
Build phobos package at a time
|
Sure this was worth the trouble? Combining all the static libs already takes 300ms on my machine. |
|
This commit increased the size of libphobos2.a by 16MiB(~20%) according to http://digger.k3.1azy.net/trend/ |
|
Well spotted, @rsw0x. This is bad. I think we should revert this. A 300ms build time improvement does not justify increasing the download size. |
|
Yeah, this is very bad. Please revert this. |
|
Well, this can't be reverted automatically now. Anyone up for Makefile surgery? |
Closed
|
@MartinNowak @rsw0x @quickfur @CyberShadow I opened #3461 to try revert this PR. Could you test that will correctly fix the problem? |
9rnsr
added a commit
to 9rnsr/phobos
that referenced
this pull request
Jul 9, 2015
This reverts commits: a928a21 (dlang#3379) 2ed7d90 (dlang#3382)
9rnsr
added a commit
that referenced
this pull request
Jul 23, 2015
Revert "Merge pull request #3379 from andralex/build-per-package"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my Powerbook, ran the command:
Took the best of three runs for baseline and proposed.
Before: 4.93s, 960270336 maximum resident set size
After: 3.85s, 618004480 maximum resident set size
On a big iron at work running Centos 6, ran the command:
Took the best of three.
Before: 5.12s, 1191664
After: 3.86s, 767252