From da79455291df5b0c7b4edc5c97472411c70d0c22 Mon Sep 17 00:00:00 2001
From: "pixeebot[bot]" <104101892+pixeebot[bot]@users.noreply.github.com>
Date: Sat, 16 Nov 2024 03:05:38 +0000
Subject: [PATCH] Introduced protections against system command injection
---
page-object/pom.xml | 10 ++++++++++
page-object/sample-application/pom.xml | 6 ++++++
.../src/main/java/com/iluwatar/pageobject/App.java | 3 ++-
3 files changed, 18 insertions(+), 1 deletion(-)
diff --git a/page-object/pom.xml b/page-object/pom.xml
index 3e78d2f0c431..9b3b3778b68c 100644
--- a/page-object/pom.xml
+++ b/page-object/pom.xml
@@ -30,6 +30,7 @@
11
11
+ 1.2.0
@@ -68,4 +69,13 @@
+
+
+
+ io.github.pixee
+ java-security-toolkit
+ ${versions.java-security-toolkit}
+
+
+
diff --git a/page-object/sample-application/pom.xml b/page-object/sample-application/pom.xml
index e74f4f539795..17722df7689b 100644
--- a/page-object/sample-application/pom.xml
+++ b/page-object/sample-application/pom.xml
@@ -33,4 +33,10 @@
1.26.0-SNAPSHOT
sample-application
+
+
+ io.github.pixee
+ java-security-toolkit
+
+
diff --git a/page-object/sample-application/src/main/java/com/iluwatar/pageobject/App.java b/page-object/sample-application/src/main/java/com/iluwatar/pageobject/App.java
index ef18ea41839f..21cfc28eb665 100644
--- a/page-object/sample-application/src/main/java/com/iluwatar/pageobject/App.java
+++ b/page-object/sample-application/src/main/java/com/iluwatar/pageobject/App.java
@@ -24,6 +24,7 @@
*/
package com.iluwatar.pageobject;
+import io.github.pixee.security.SystemCommand;
import java.awt.Desktop;
import java.io.File;
import java.io.IOException;
@@ -79,7 +80,7 @@ public static void main(String[] args) {
} else {
// java Desktop not supported - above unlikely to work for Windows so try instead...
- Runtime.getRuntime().exec("cmd.exe start " + applicationFile);
+ SystemCommand.runCommand(Runtime.getRuntime(), "cmd.exe start " + applicationFile);
}
} catch (IOException ex) {