Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Multiple Paths for fds add #79

Merged
merged 4 commits into from Jul 19, 2021
Merged

Support Multiple Paths for fds add #79

merged 4 commits into from Jul 19, 2021

Conversation

mohithg
Copy link
Contributor

@mohithg mohithg commented Jul 19, 2021

  • fds add right now only supports one path (or .) but we need to make fds add support multiple paths
    eg: fds add path1/file1 path2

…unction typing to support List[str] instead of str (#71)

Co-authored-by: Mohith G <mohithgm@gmail.com>
@mohithg mohithg linked an issue Jul 19, 2021 that may be closed by this pull request
* Support multiple paths in dvc

* support multiple paths in git

* Add tests

* Add fds test

* Add test for fds

* Add test for dvc

* Add test for git

* Bug fix for all

* Add a fix for more performance
@mohithg mohithg requested a review from guysmoilov July 19, 2021 12:00
@guysmoilov guysmoilov added good first issue Good for newcomers ux UX improvement labels Jul 19, 2021
@guysmoilov guysmoilov merged commit c743e8b into main Jul 19, 2021
@guysmoilov guysmoilov deleted the multiple-paths branch July 19, 2021 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers ux UX improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support multiple paths in fds add
3 participants