Bug/regression fixes, add terms in download dialog #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per https://web.archive.org/web/20190116170516/https://www.marcozehe.de/2018/09/22/wai-aria-menus-and-why-you-should-generally-avoid-using-them/ - it doesn't seem like we're using this role as intended in most cases, so I'm doing a blanket removal to see if there are adverse UI impacts or new accessibility issues being reported. With this role, menus like the Edit menu in the files table report an issue (from AXE) with the menu not containing child elements with the right role (i.e. menuitem), and a seemingly spurious 'li elements must be contained in a ul or ol' error. Conflicts: src/main/webapp/file.xhtml
id="versionLink" appears once per row in the versionTable - not sure why that is only an accessibility issue (i.e. not a problem for jsp generation). The id wasn't used anywhere that I can see.
When editing the metadata allowed in a dataset, if you select 'Use browse/search facets from <root dataverse>, all of the disabled entries have insufficient contrast. One option to fix this would be increasing the contrast, however, setting aria-disabled=true also works - disabled entries don't have to have high contrast.
works via PrimeFaces to assign a label to the row selection to avoid a ARIA toggle fields must have an accessible name
Links with the same name should have similar purpose This change uses the i18n names of individual previewers for the preview button, which reduces the ambiguity, but doesn't give the preview in each row a unique title. (I.e. two images still have 'View Image' as the title, but 'Read Text' for a text preview would now be different.) We could add the filename to the title to make this fully unique, either with/without using the previewer names. Note: Deque says this is an issue unless the links are 'intentionally ambiguous' - not sure if that includes assuming the row context is enough.
the existing code had labeling, but the ids labels used to refence inputs were incorrect. This commit also adds a label for CVV fields - (not multival in compound fields which may or may not exist in the wild).
tabindex>0 generated a warning. In this case, the tabindex is on a <span> within an <a> which already causes a tab stop. So I've removed the tabindex altogether, which I think just removes a redundant stop on this element.
Since the support form in in the menu's <ul>, it needs to be wrapped in a <li> to avoid a warning
same as for other role=menu
used an aria-labelledby to associate the a element with the text in the a child element (#userDisplayIfoTitle).
Colors are a complex issue - this commit has a few changes that remove Axe warnings related to links, muted text, and some earning/danger labels. Several of these, e.g. labels come from bootstrap and so will change with bootstrap version. In many cases, Axe can't determine whether there is an issue due to gradient backgrounds and/or overlapping elements.
This change does not alter existing behaviour. Anyway with current or future use of the ~/.aws profiles/credentials may continue to do so. This is useful to serve traditional installations, testing with AWS CLI etc. Containerized installations profit from not having to generate the AWS CLI specific files. Also testing gets easier by providing credentials via env or system props.
- Make list left aligned, much better to read - Add missing but required options `dataverse.files.<id>.type` and `dataverse.files.<id>.label`
added css to keep font-size 30px for h1 Login element (which it was when it was an h2 element)
mismatched id/aria-labelledby values
this applies the File Count label to the individual row tds rather than to the header which shows a file count.
the row labels avoid the select check boxes having a warning about no text the labels/message boxes for the file name and directory label inputs were broken the facet for the empty header stops a warning about no screen reader accessible text for that metadata column header
Conflicts: src/main/webapp/filesFragment.xhtml
fixes to label for= values h2 -> h1 for lvel-one heading
forgot to change this back after realizing we needed the uri for other exports also - termsofUse capitalization messed with DDI export
FWIW: the rendered attribute isn't supported on selectItem elements
5733 s3 cred chain
…-Accessibility IQSS/8321 Accessibility
Conflicts: src/main/webapp/dataset-license-terms.xhtml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes per review, bug fixes, merge with latest dev, etc. (I think most of the changes are from the accessibility PR - only a few files have changes related to multi-license work.)