Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create tests for `ride-hailing/NeedParams` using jest. #22

Closed
haialaluf opened this Issue Sep 5, 2018 · 9 comments

Comments

Projects
None yet
5 participants
@haialaluf
Copy link
Member

haialaluf commented Sep 5, 2018

first-timers-only

This issue is tagged :octocat: first-timers-only. It is only for people who have never contributed to open source before, and are looking for an easy way take their first steps.

Consider this your chance to dip your toe into the world of open-source, and get some bragging rights for writing code that makes drones fly, lets cars find charging stations, helps people and goods get from place to place, and more.

Find more first-timers-only issues from DAV Foundation here.

Thank you for your help ❤️

What is this project?

DAV (Decentralized Autonomous Vehicles) is a new foundation working to build an open-source infrastructure for autonomous vehicles (cars, drones, trucks, robots, and all the service providers around them) to communicate and transact with each other over blockchain.

As an organization that believes in building a large community of open-source contributors, we often create issues like this one to help people take their first few steps into the world of open source.

dav-js

This SDK enabled integrating any client side JS and NodeJS code with the DAV Network.

How you can help

The Issue

Create tests for ride-hailing/NeedParams using jest.

You need to create tests to check that the serialize and deserialize methods work as expected.

Please use the test file for class NeedParams as a basis for your new code.

  • Function serialize in class NeedParams must return a JSON object that contains all properties defined in the NeedParams instance.

  • Function deserialize in class NeedParams receives a JSON string and must initialize all the properties of the NeedParams instance with the values in the JSON string.

needParams1.desrialize(needParams2.serialize()) == needParams2 must therefore always be true.

NOTE: Some names are changed between protocol string representation of instance properties:

  • location is internally represented as { lat , lon } but serialized as { latitude , longitude }
  • Private properties are internally prefixed with _ but serialized without the prefix. i.e. _protocol becomes protocol

Contributing to dav-js

  • Make sure this issue is labeled up-for-grabs and not labeled claimed, to verify no one else is working on it.
  • Comment in this issue that you would like to do it.
  • Open dav-js GitHub page and click the ★ Star and then ⑂ Fork buttons.
  • Clone a copy to your local machine with $ git clone git@github.com:YOUR-GITHUB-USER-NAME/dav-js.git
  • Code Code Code
  • Once you've made sure all your changes work correctly and committed all your changes, push your local changes back to github with $ git push -u origin master
  • Visit your fork on GitHub.com (https://github.com/YOUR-USER-NAME/dav-js) and create a pull request for your changes.
  • Make sure your pull request describes exactly what you changed and references this issue (include the issue number in the title like this: #7)
  • Please do not fix more than one issue at a time. Your pull request should only fix what is described in this issue.

Asking for help

We appreciate your effort in taking the time to work on this issue and help out the open source community and the foundation. If you need any help, feel free to ask below or in our gitter channel. We are always happy to help 😄

@ericcgu

This comment has been minimized.

Copy link

ericcgu commented Sep 19, 2018

I'd like to take a shot.

@TalAter

This comment has been minimized.

Copy link
Member

TalAter commented Sep 20, 2018

Go ahead @ericcgu 👍

@TalAter

This comment has been minimized.

Copy link
Member

TalAter commented Oct 2, 2018

@ericcgu are you still interested in doing this issue?

@srdmathur

This comment has been minimized.

Copy link

srdmathur commented Nov 15, 2018

Hi,
I would like to do it.

@srdmathur

This comment has been minimized.

Copy link

srdmathur commented Nov 17, 2018

Hi,
I would like to do it.

Is this issue, still persist?

@mariolo1985

This comment has been minimized.

Copy link
Member

mariolo1985 commented Nov 17, 2018

Hi @srdmathur sorry for the late response. This issue still persist. You can start working on it if you still want it 👍

@srdmathur

This comment has been minimized.

Copy link

srdmathur commented Nov 19, 2018

Thanks for your response. I will start working on this now onwards.

srdmathur pushed a commit to srdmathur/dav-js that referenced this issue Nov 19, 2018

@srdmathur

This comment has been minimized.

Copy link

srdmathur commented Nov 19, 2018

Hi I have coded the changes but the build is failing on Travis for the following commands :

  1. tsc
  2. typedoc
  3. create-dist

on my local, these commands are working. Can you please check on this?

@mariolo1985

This comment has been minimized.

Copy link
Member

mariolo1985 commented Dec 14, 2018

Hi @srdmathur, the create-dist command outputs new files that the build is looking for and it is failing there. Good work with the tests! I have merged your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.