New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded code for messageParams (first-timers-only) #66

Closed
TalAter opened this Issue Sep 29, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@TalAter
Member

TalAter commented Sep 29, 2018

first-timers-only

This issue is tagged :octocat: first-timers-only. It is only for people who have never contributed to open source before, and are looking for an easy way take their first steps.

Consider this your chance to dip your toe into the world of open-source, and get some bragging rights for writing code that makes drones fly, lets cars find charging stations, helps people and goods get from place to place, and more.

Find more first-timers-only issues from DAV Foundation here.

Thank you for your help ❤️

What is this project?

DAV (Decentralized Autonomous Vehicles) is a new foundation working to build an open-source infrastructure for autonomous vehicles (cars, drones, trucks, robots, and all the service providers around them) to communicate and transact with each other over blockchain.

As an organization that believes in building a large community of open-source contributors, we often create issues like this one to help people take their first few steps into the world of open source.

dav-js

This repo contains the DAV JavaScript SDK. This SDK allows developers to build applications and servers that connect to the DAV network. For example, allowing a drone to find charging stations, or an autonomous car to ask for traffic data.

How you can help

In order to foster a community that is welcoming for open source contributions, it is important for us to have good test coverage. And good tests, are simple readable tests.

There's a good opportunity to simplify one of our tests:

In src/Bid.test.ts when messageParams is defined we give it a value (a new MessageParams object). But that value is immediately overwritten in the beforeEach function. Change the code so that messageParams is just defined, and isn't immediately assigned a value. While we're at it, and since this is TypeScript, give it a type of MessageParams.

messageparams

After making your changes, make sure the tests still pass by running npm run jest

Contributing to dav-js

  • Make sure this issue is labeled up-for-grabs and not labeled claimed, to verify no one else is working on it.
  • Comment in this issue that you would like to do it.
  • Open dav-js GitHub page and click the ★ Star and then ⑂ Fork buttons.
  • Clone a copy to your local machine with $ git clone git@github.com:YOUR-GITHUB-USER-NAME/dav-js.git
  • Code Code Code
  • Once you've made sure all your changes work correctly and committed all your changes, push your local changes back to github with $ git push -u origin master
  • Visit your fork on GitHub.com (https://github.com/YOUR-USER-NAME/dav-js) and create a pull request for your changes.
  • Make sure your pull request describes exactly what you changed and references this issue (include the issue number in the title like this: #7)
  • Please do not fix more than one issue at a time. Your pull request should only fix what is described in this issue.

Asking for help

We appreciate your effort in taking the time to work on this issue and help out the open source community and the foundation. If you need any help, feel free to ask below or in our gitter channel. We are always happy to help 😄

@StevenJW

This comment has been minimized.

Show comment
Hide comment
@StevenJW

StevenJW Sep 30, 2018

Contributor

I would like to do this!

Contributor

StevenJW commented Sep 30, 2018

I would like to do this!

@mariolo1985

This comment has been minimized.

Show comment
Hide comment
@mariolo1985

mariolo1985 Sep 30, 2018

Member

hey @StevenJW please go right ahead 😄

Member

mariolo1985 commented Sep 30, 2018

hey @StevenJW please go right ahead 😄

@mariolo1985

This comment has been minimized.

Show comment
Hide comment
@mariolo1985

mariolo1985 Oct 14, 2018

Member

Thanks for pushing through especially with the build issues @StevenJW 👍 Please check back every once in a while to see what new issues we need help with. Thanks again!

Member

mariolo1985 commented Oct 14, 2018

Thanks for pushing through especially with the build issues @StevenJW 👍 Please check back every once in a while to see what new issues we need help with. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment