Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround/fix for issue #68 #70

Merged
merged 1 commit into from Sep 9, 2019

Conversation

@Shados
Copy link
Contributor

commented Sep 8, 2019

Closes #68, but I think probably upstream nixpkgs should also be changed -- ideally, I think both pkgsMusl and pkgsi686Linux should explicitly set both localSystem and crossSystem in the stdenv.hostPlatform == stdenv.buildPlatform case, rather than relying on the behaviour around default/null crossSystem arguments to nixpkgs.

@delroth

This comment has been minimized.

Copy link

commented Sep 8, 2019

Tested with a nix-build on pkgsi686Linux, seems to be working. Thanks for the quick fix!

Have you opened an issue upstream? Would be nice to cross-ref it here.

@Shados

This comment has been minimized.

Copy link
Contributor Author

commented Sep 8, 2019

I haven't, I'll probably get around to writing a nixpkgs PR later this week.

@johanot
johanot approved these changes Sep 9, 2019
Copy link
Contributor

left a comment

LGTM.

@johanot johanot merged commit 3370e8d into DBCDK:master Sep 9, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.