New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for HAProxy 1.8.1 #7

Closed
pietervogelaar opened this Issue Dec 15, 2017 · 6 comments

Comments

Projects
None yet
4 participants
@pietervogelaar

pietervogelaar commented Dec 15, 2017

Do you have any idea how to support version 1.8.1?

The file haproxy-systemd-wrapper is no longer available in 1.8.1. I removed the install and chmod step in the build for it. With that I was able to build the package. However starting /usr/sbin/haproxy directly doesn't seem to work:

/usr/lib/systemd/system/haproxy.service

[Unit]
Description=HAProxy Load Balancer
After=syslog.target network.target

[Service]
ExecStart=/usr/sbin/haproxy -f /etc/haproxy/haproxy.cfg -p /var/run/haproxy.pid
ExecReload=/bin/kill -USR2 $MAINPID
KillMode=mixed

[Install]
WantedBy=multi-user.target
@khdevel

This comment has been minimized.

Show comment
Hide comment
@khdevel

khdevel Dec 28, 2017

Contributor

@pietervogelaar I also need such RPM, so I have worked on it and here is my PR: #8

Please checkout if it works for you. My build is for Centos7 and it seems to work fine.
I did not check it with special configuration because I have to migrate from 1.5, so it needs a time and tests. But the main process with default configuration works good.

Remark:
When I set an option -W or put master-worker in configuration haproxy.service was in failed state after the systemctl stop haproxy.service was performed. So, it needs to be checked what is the reason of that and fix it.

Contributor

khdevel commented Dec 28, 2017

@pietervogelaar I also need such RPM, so I have worked on it and here is my PR: #8

Please checkout if it works for you. My build is for Centos7 and it seems to work fine.
I did not check it with special configuration because I have to migrate from 1.5, so it needs a time and tests. But the main process with default configuration works good.

Remark:
When I set an option -W or put master-worker in configuration haproxy.service was in failed state after the systemctl stop haproxy.service was performed. So, it needs to be checked what is the reason of that and fix it.

@DBezemer

This comment has been minimized.

Show comment
Hide comment
@DBezemer

DBezemer Feb 12, 2018

Owner

Finalized in 6602959

Owner

DBezemer commented Feb 12, 2018

Finalized in 6602959

@DBezemer DBezemer closed this Feb 12, 2018

@khdevel

This comment has been minimized.

Show comment
Hide comment
@khdevel

khdevel Feb 14, 2018

Contributor

Thank you!

Contributor

khdevel commented Feb 14, 2018

Thank you!

@beeva-carlosleon

This comment has been minimized.

Show comment
Hide comment
@beeva-carlosleon

beeva-carlosleon Apr 4, 2018

Remark:
When I set an option -W or put master-worker in configuration haproxy.service was in failed state after the systemctl stop haproxy.service was performed. So, it needs to be checked what is the reason of that and fix it.

I am having the same issue. Do you know what is going on?

Thanks

beeva-carlosleon commented Apr 4, 2018

Remark:
When I set an option -W or put master-worker in configuration haproxy.service was in failed state after the systemctl stop haproxy.service was performed. So, it needs to be checked what is the reason of that and fix it.

I am having the same issue. Do you know what is going on?

Thanks

@DBezemer

This comment has been minimized.

Show comment
Hide comment
@DBezemer

DBezemer Apr 4, 2018

Owner

@beeva-carlosleon master-worker probably requires to run haproxy without a pid file, I'll do some testing and if this is the case will release an updated service file together with the 1.8.5 release

Owner

DBezemer commented Apr 4, 2018

@beeva-carlosleon master-worker probably requires to run haproxy without a pid file, I'll do some testing and if this is the case will release an updated service file together with the 1.8.5 release

@beeva-carlosleon

This comment has been minimized.

Show comment
Hide comment
@beeva-carlosleon

beeva-carlosleon Apr 5, 2018

Thanks @DBezemer and great work! :)

beeva-carlosleon commented Apr 5, 2018

Thanks @DBezemer and great work! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment