OL: fix style type switching and stale event listeners on style change#287
Merged
dannyleech merged 1 commit intoMay 20, 2026
Merged
Conversation
dannyleech
approved these changes
May 20, 2026
Contributor
|
Looks great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue switching between different types via the mapStylesPlugin, e.g going from vector to raster would try load using the wrong path and error. The tileloadend listener would also end up stale for vector types.
Combined layer creation logic into
createMapStyleLayer, dropping the reuse of the source so raster now recreates to match the other types. Listeners are now kept up to date on switches with theonBaseSourceChangecallback.Removed the unused
tileLayerandsourceproperties form the provider instance to avoid keeping them in sync.