Add screen for late renewals #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From:https://eaflood.atlassian.net/browse/RUBY-1001 This adds an ad-hoc screen when the renewal link is hit after a registration has already been renewed
From: https://eaflood.atlassian.net/browse/RUBY-1002 This adds an ad-hoc screen for when the magic link is used past the renewal window
Cruikshanks
approved these changes
May 15, 2020
| @@ -7,3 +7,7 @@ en: | |||
| paragraph2_html: "If you still need to register as a waste carrier, broker or dealer then <a href=\"%{link_to_new_registration}\">make a new registration.</a>" | |||
| paragraph3: "If you want to discuss this registration, contact the Environment Agency. You will need your registration number." | |||
| paragraph4_html: "Environment Agency helpline: 03708 506 506 (Monday to Friday, 8am to 6pm) <a href=\"mailto:nccc-carrierbroker@environment-agency.gov.uk\">nccc-carrierbroker@environment-agency.gov.uk</a>" | |||
| past_renewal_window: | |||
| heading: "That renewal has expired" | |||
| paragraph1: "Your registration expired over 1 month ago, so you cannot renew." | |||
There was a problem hiding this comment.
Had the discussion with @cintamani and we agree this is wrong. Currently, with the grace window being 90 days a registration would have had to expire more than 3 months ago to be ineligible.
And if the grace window comes back down to 5 days, then a registration could be less than 1 month expired and still see this message.
We've agreed to merge for now (everything else is tip-top!) and will raise the content issue with our UCD team.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From: https://eaflood.atlassian.net/browse/RUBY-1002
This adds an ad-hoc screen for when the magic link is used past the renewal window