New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webpack vue sample #73

Merged
merged 6 commits into from Nov 14, 2018

Conversation

Projects
None yet
2 participants
@S-H-GAMELINKS
Contributor

S-H-GAMELINKS commented Oct 18, 2018

Add sample(using Vue.js)

@DEGoodmanWilson DEGoodmanWilson self-requested a review Oct 18, 2018

@DEGoodmanWilson

This is pretty cool! I'd love to include this sample (it's exactly something I'd been thinking about doing for about a year).

However, it looks like you have included the entire luna library source code in duplicate in examples/project_template_webpack_vue/luna/, which is a problem.

@S-H-GAMELINKS S-H-GAMELINKS force-pushed the S-H-GAMELINKS:add_webpack_vue_sample branch from 04d6456 to 86ce400 Oct 18, 2018

@S-H-GAMELINKS

This comment has been minimized.

Contributor

S-H-GAMELINKS commented Oct 18, 2018

Oh, sorry.

Fixed it ! (remove luna library source code )

@DEGoodmanWilson

Thanks for the update—I apologize that I've been slow merging your PR! It looks like with the latest changes, there are some small changes I would like to see, to use std::array instead of std::experimental::array

@@ -4,6 +4,7 @@
#include "logger.h"
#include <string>
#include <vector>
#include <experimental/array>

This comment has been minimized.

@DEGoodmanWilson

DEGoodmanWilson Nov 12, 2018

Owner

There shouldn't be any nneed for the experimental qualifier. gcc 4.9 forwards support std::array.

@S-H-GAMELINKS S-H-GAMELINKS force-pushed the S-H-GAMELINKS:add_webpack_vue_sample branch from d4f3c2b to 1fe83ee Nov 13, 2018

@S-H-GAMELINKS

This comment has been minimized.

Contributor

S-H-GAMELINKS commented Nov 13, 2018

Using std::array in this commit !

84e2df7

And /api/endpoint is fix.

59d896e

@DEGoodmanWilson DEGoodmanWilson merged commit e12cf80 into DEGoodmanWilson:master Nov 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment