Holy RAM

[oojacoboo]

I guess this is why it's so slow. Why is this service taking up so much memory?!

[jakubmisek]

Thank you for reporting this. I know it's happening but we couldn't find out why.

May I ask you for more details? I'd be happy to fix this asap.

• what is the size of your workspace
• maybe used packages?
• for how long is it running, how long is the VSCode workspace opened
• or any steps to reproduce?

I'd appreciate any info.

[oojacoboo]

Sure. The entire workspace is nearly 20GB in total. But, that's all files and not just PHP files, which the language server should only be processing. I'm using the following command which is giving me roughly 1GB for all the PHP files in the workspace.

find . -name "*.php" -exec du -ch {} \; | awk '{total+=$1}END{print total}'

The editor has been running for maybe a day - not even sure. VSCode update and restarts itself a lot and I've had to restart it a lot recently with this plugin. That shouldn't be a huge consideration or issue. It's not like it's been running beyond what would be considered normal.

No idea on reproducing. This issue doesn't occur with Intelliphense.

[d8vjork]

@oojacoboo Sure that doesn't count vendor folder or anything?

[oojacoboo]

It does count the vendor directories, as it should. They must be indexed and used in auto-complete.

[jakubmisek]

Thank you! Yes, vendor should be included ... @d8vjork may have found one possible bug (#285 (comment)) but it would not cause 6gigs of RAM used.

We'll do more testing, I'd be very interested in reproducing this issue on our machines; we'd perform complete memory profiling ...

[oojacoboo]

It gets worse. Quitting VSCode isn't killing this node server or whatever is handling the indexing. Of course, VSCode was force-quit since it was bringing my system to it's knees by draining available memory and causing system paging.

It ended up corrupting memory on dozens of other apps in the process. Going to have to move back to Intelliphense until this issue is resolved.

[jakubmisek]

I would really love to be able to reproduce this issue :-)

There is probably an infinite loop happening .. we'll keep trying.

[ggolda]

@jakubmisek have the same issue, maximum I had was 8GB of RAM after executing lots of composer commands related to install/update. Maybe extension doesn't free memory if file is no longer in use?

[jakubmisek]

@ggolda thank you for letting me know - I'll try composer commands subsequently. Is it something specific? Installing packages? Removing packages? Updating?

[ggolda]

@jakubmisek just tried it again, was doing a global laravel update via composer update several times, followed by composer remove {package-name} and composer require {package-name} and my RAM consumption went from 1GB idle to 5GB after executing these commands. Also VSCode reported that it is trying to index 46k files after each command (I guess its fine in this case).

RAM consumption haven't gone down after leaving it in this state for a couple minutes without doing anything.

[jakubmisek]

@ggolda I have a suspicion there is a memory leak in parsing .phar files .. I'll try updating Laravel a few times on various OS's

[jakubmisek]

alright, every time I update/copy a new phpstan.phar file, it consumes about 300MB more RAM and never return it back

[jakubmisek]

I've fixed the memory leak happening when updating a .phar files.

We'll prepare a pre-release within a day.

There are other memory-related improvements for future updates, but this one is fixing the issue at least for me (it happened on most composer update actions)

[jakubmisek]

please update to pre-release 1.32.12898