phptools deletel code `join()` #bug

[kokwiw]

env

• ubuntu 20.04
• vscode 1.88.1
• php 7.4.3
• phptools v1.50.15906

why $subjects = join(" ", $subject); become $subjects ?

before phptools

   public function getNoticeTitle()
    {
        list(
            'studentGrade' => $studentGrade,
            'subject' => $subject,
            'region' => $region,
            'lessonDuration' => $lessonDuration,
            'feeDeal' => $feeDeal,
            ) = $this->getPublicInfo();
        $subjects = join(" ", $subject);

        return "[{$studentGrade} {$subjects} (HK\${$feeDeal} | {$lessonDuration}) {$region}]";
    }

after phptools

    public function getNoticeTitle()
    {,
        list(
            'studentGrade'   => $studentGrade,
            'subject'        => $subject,
            'region'         => $region,
            'lessonDuration' => $lessonDuration,
            'feeDeal'        => $feeDeal,
        ) = $this->getPublicInfo();
        $subjects                                                                                                                                                                                                            = join(" ", $subject);

        return "[{$studentGrade} {$subjects} (HK\${$feeDeal} | {$lessonDuration}) {$region}]";
    }

[Miloslav]

Hello,

Thank you very much for reporting this. This is indeed weird. Let us investigate and fix it ASAP.

Thanks!

[Miloslav]

We've been able to identify the issue and we are preparing the fix. It's related to php.format.rules.alignConsecutiveAssignments settings and it doesn't delete (we have a mechanism that would prevent any deletion), it just indents very far to the right.

Thanks again

[kokwiw]

your are rigiht.sorry I don't notice the indent in the right;

[Miloslav]

No problem. We're glad you've reported it. We've fixed it and it will be available in the next update.

Thanks!