Go To Definition to get to constructor being called

[still-dreaming-1]

I'm using the VSCode extension. For the same reason that using Go To Definition to go to the definition of a method being called is useful and desirable, it would also be nice if there was a way to use this feature for going to the constructor being called.

Static Example

class A {
    public function __construct() {
    }
}

class B extends A {
    public static function make(): static {
        return new static();
    }
}

In this case, Go To Defition on the static in the context of it being constructed (when new is in front of it) should take you to that the constructor being called, which in this case is the constructor from class A. Especially when the user doesn't know where the constructor is defined, if the tool can take them right there, that could be quite helpful. Technically you don't really know which constructor it is calling because something else could extend B and have its own constructor, but I think it's better for it to take you somewhere than nowhere.

Self Example

class A {
    public function __construct() {
    }
}

class B extends A {
    public static function make(): self {
        return new self();
    }
}

This is the same as the previous example except it uses the self keyword instead of static. Since the constructor for B is defined in Class A, it should still take you to that constructor.

Hard Coded Class Name Example

class A {
    public function __construct() {
    }
}

class B extends A {
    public static function make(): B {
        return new B();
    }
}

This is the same as the previous example except it uses the B instead of self. In this case, the effect is the same since the constructor for B is defined in Class A.

That is how I would prefer it to work, but if you want B to continue to take them to the definition of class B instead of the constructor, you could perhaps allow using Go To Definition on the keyword new to get to the constructor, as that currently doesn't seem to be used for anything.

[jakubmisek]

Thank you for the suggestion @still-dreaming-1 ,

I'll take a look at that!

Navigation to new static can also show constructors of all the derived classes, if it makes sense?

[still-dreaming-1]

Ah, I think I configured my editor to always go to the first option and forgot it can have multiple. Yes I think that makes sense, for the above static example, for it to show all constructors defined in classes that are derived from B. It would also show the constructor defined in A as that may be the one that gets called.

[jakubmisek]

Implemented in latest 1.59

thanks!