Incorrect Declaration .. must be compatible with ...

[Disservin]

The following generates an error from devsense

<?php

require_once 'vendor/autoload.php';

use Carbon\Carbon as BaseCarbon;

class MyCarbon extends BaseCarbon {
    public static function createFromFormat($format, $time, $timezone = null): ?static
    {
        return parent::createFromFormat($format, $time, $timezone);
    }
}

Error:

Declaration of MyCarbon::createFromFormat($format, $time, $timezone = null): static must be compatible with Carbon::createFromFormat($format, $time, $timezone = null): mixed|null

however, this error seems to be incorrect, both php index.php show no error as well as PHP Intelephense from Ben Mewburn.

Changing the return type to an incorrect one produces a real php error, i.e. : ?int

Fatal error: Declaration of MyCarbon::createFromFormat($format, $time, $timezone = null): ?int must be compatible with Carbon\Carbon::createFromFormat($format, $time, $timezone = null): ?Carbon\Carbon in index.php on line 8

[jakubmisek]

@Disservin thank you for reporting the issue!

Will be fixed.

[jakubmisek]

fixed in the next update, thanks!

[Disservin]

nice, thank you too

[Disservin]

Hi again! After updating the original issue went away but the function's return type when used later is still slightly wrong I think.

nullable static, became just static? this loses information about it maybe being null?

[Disservin]

Also when changing ?static to ?self the return type suddenly includes bool and also no null ?

[jakubmisek]

thank you for the screenshots;

• ?static -> static: we just oversimplify the tooltip. I'll try to fix this, so it's not confusing.

• It looks like the return type fallbacks to the PHPDoc from the base class (https://www.php.net/manual/en/datetime.createfromformat.php). We should handle this case better definitelly.

[jakubmisek]

'createFromFormat()' signature will be correct in IntelliSense, so the corresponding warnings will be more precise.