Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update content when asking for candidate’s name in references flow #3335

Merged
merged 1 commit into from Nov 4, 2020
Merged

Update content when asking for candidate’s name in references flow #3335

merged 1 commit into from Nov 4, 2020

Conversation

paulrobertlloyd
Copy link
Contributor

@paulrobertlloyd paulrobertlloyd commented Nov 4, 2020 •
edited

Context

Update content:

  • Revised title for page that asks for candidate’s own name
  • Add extra paragraph

Plus fix a few bugs on this page:

  • Move error summary above h1
  • Use hint.text not hint_text to ensure hint text appears

…and also do a bit of house cleaning:

  • Add localised strings for labels and hints

Changes proposed in this pull request

Before After
before after

Guidance to review

Link to Trello card

https://trello.com/c/Fxj6XLom/

Things to check

  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • API release notes have been updated if necessary
  • New environment variables have been added to the Azure config

@tijmenb tijmenb temporarily deployed to apply-for-te-2488-candi-w58b4z November 4, 2020 16:28 Inactive
davidgisbey
davidgisbey approved these changes Nov 4, 2020
View reviewed changes
Copy link
Contributor

@davidgisbey davidgisbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@paulrobertlloyd paulrobertlloyd force-pushed the 2488-candidate-name-in-reference-flow branch from 1976263 to 7819278 Compare November 4, 2020 17:09
@paulrobertlloyd paulrobertlloyd temporarily deployed to apply-for-te-2488-candi-w58b4z November 4, 2020 17:09 Inactive
@paulrobertlloyd paulrobertlloyd added Candidate Candidate facing issue Content labels Nov 4, 2020
@paulrobertlloyd paulrobertlloyd merged commit b0ca21a into master Nov 4, 2020
@paulrobertlloyd paulrobertlloyd deleted the 2488-candidate-name-in-reference-flow branch November 4, 2020 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidgisbey davidgisbey davidgisbey approved these changes

Assignees
No one assigned
Labels
Candidate Candidate facing issue Content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paulrobertlloyd @davidgisbey @tijmenb