From 02c3132c5d9a8c51e1d4129d2c23a913626805ce Mon Sep 17 00:00:00 2001 From: Davide Dippolito Date: Thu, 21 Mar 2024 12:23:01 +0000 Subject: [PATCH] Temporarily allow legacy job role in job alerts --- app/presenters/subscription_presenter.rb | 7 +++++++ spec/presenters/subscription_presenter_spec.rb | 4 ++++ 2 files changed, 11 insertions(+) diff --git a/app/presenters/subscription_presenter.rb b/app/presenters/subscription_presenter.rb index f07c792e49..7e8cc34466 100644 --- a/app/presenters/subscription_presenter.rb +++ b/app/presenters/subscription_presenter.rb @@ -5,6 +5,7 @@ class SubscriptionPresenter < BasePresenter SEARCH_CRITERIA_SORT_ORDER = %w[organisation_slug keyword location + job_roles teaching_job_roles teaching_support_job_roles non_teaching_support_job_roles @@ -50,6 +51,8 @@ def search_criteria_field(field, value) def job_roles_filter(field, value) case field + when "job_roles" + render_legacy_job_roles_filter(value) when "teaching_job_roles" render_teaching_job_roles_filter(value) when "teaching_support_job_roles" @@ -71,6 +74,10 @@ def render_location_filter(location, radius) end end + def render_legacy_job_roles_filter(value) + { job_role: value.map { |role| I18n.t("helpers.label.publishers_job_listing_job_role_form.job_role_options.#{role}") }.join(", ") } + end + def render_teaching_job_roles_filter(value) { teaching_job_roles: value.map { |role| I18n.t("helpers.label.publishers_job_listing_job_role_form.job_role_options.#{role}") }.join(", ") } end diff --git a/spec/presenters/subscription_presenter_spec.rb b/spec/presenters/subscription_presenter_spec.rb index 5f2a172b28..5f42e7e302 100644 --- a/spec/presenters/subscription_presenter_spec.rb +++ b/spec/presenters/subscription_presenter_spec.rb @@ -102,6 +102,7 @@ phases: %w[secondary sixth_form_or_college], organisation_slug: organisation.slug, radius: "10", + job_roles: %w[headteacher head_of_year_or_phase], teaching_job_roles: %w[headteacher head_of_year_or_phase], teaching_support_job_roles: %w[teaching_assistant], non_teaching_support_job_roles: %w[it_support], @@ -119,6 +120,7 @@ organisation_type_basic(organisation).titleize, "keyword", "location", + "job_role", "teaching_job_roles", "teaching_support_job_roles", "non_teaching_support_job_roles", @@ -140,6 +142,7 @@ something_else: "testing", phases: %w[secondary sixth_form_or_college], organisation_slug: organisation.slug, + job_roles: %w[headteacher head_of_year_or_phase], teaching_job_roles: %w[headteacher head_of_year_or_phase], teaching_support_job_roles: %w[teaching_assistant], non_teaching_support_job_roles: %w[it_support], @@ -155,6 +158,7 @@ organisation_type_basic(organisation).titleize, "keyword", "location", + "job_role", "teaching_job_roles", "teaching_support_job_roles", "non_teaching_support_job_roles",