Skip to content

Comments

Identify some reputation fields#200

Merged
lethosor merged 2 commits intoDFHack:masterfrom
dscorbett:reputation
Jul 13, 2017
Merged

Identify some reputation fields#200
lethosor merged 2 commits intoDFHack:masterfrom
dscorbett:reputation

Conversation

@dscorbett
Copy link
Contributor

The new enum is related to unit_relationship_type. The enum values given names are those for which strings appear in legends mode. 20 and 21 are attested and are probably Poet and Bard but I couldn’t verify that.

<stl-vector name='types'>
<enum base-type='int32_t'>
0
<enum-item name='Hero'/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A more complete list, extracted from what looks to be conversation-related code:
0 - hero
1 - close friend
2 - really irritating
3 - my partner
4 - brawler
5 - villain
6 - good for a deal now and then
7 - a pleasure to speak with
8 - killer
9 - murderer
10 - comrade
11 - worthy of respect
12 - not fit to rule
13 - enemy fighter
14 - on my side
15 - thug
16 - brigand
17 - loyal soldier
18 - monster
19 - storyteller
20 - poet
21 - bard
22 - dancer
23 - quarreler
24 - flatterer
25 - hunter
26 - protector of the defenseless

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added all these to the pull request, taking their names from the <rep_*> elements of the XML dump.

@lethosor lethosor merged commit 740c583 into DFHack:master Jul 13, 2017
@dscorbett dscorbett deleted the reputation branch July 13, 2017 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants