Identify some reputation fields#200
Merged
lethosor merged 2 commits intoDFHack:masterfrom Jul 13, 2017
Merged
Conversation
quietust
reviewed
Jun 22, 2017
| <stl-vector name='types'> | ||
| <enum base-type='int32_t'> | ||
| 0 | ||
| <enum-item name='Hero'/> |
Member
There was a problem hiding this comment.
A more complete list, extracted from what looks to be conversation-related code:
0 - hero
1 - close friend
2 - really irritating
3 - my partner
4 - brawler
5 - villain
6 - good for a deal now and then
7 - a pleasure to speak with
8 - killer
9 - murderer
10 - comrade
11 - worthy of respect
12 - not fit to rule
13 - enemy fighter
14 - on my side
15 - thug
16 - brigand
17 - loyal soldier
18 - monster
19 - storyteller
20 - poet
21 - bard
22 - dancer
23 - quarreler
24 - flatterer
25 - hunter
26 - protector of the defenseless
Contributor
Author
There was a problem hiding this comment.
I have added all these to the pull request, taking their names from the <rep_*> elements of the XML dump.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new enum is related to
unit_relationship_type. The enum values given names are those for which strings appear in legends mode. 20 and 21 are attested and are probablyPoetandBardbut I couldn’t verify that.