Remove/replace old hotkeys-as-keybindings system

[PeridexisErrant]

It made sense when DFHack was young and didn't have the keybinding command.

These days, it's cruft and with the number of commands available it's increasingly likely to be triggered by accident, by someone who names their burrow something like "points", "lever", "source", "liquids", autofarm"...

We just don't need it and keeping such an old feature around isn't helping anyone.

[warmist]

Yes :)

[PeridexisErrant]

Whoever takes out this code should also remove the note about it in the docs here.

[lethosor]

Yeah, I tried doing this at one point, but I ran into a bunch of older code that was more complicated to remove.
From what I can tell, bindings like F1@dwarfmode should be equivalent, so we might as well get rid of the old system.

[lethosor]

I did run into someone using this (intentionally) on Reddit, which was the inspiration for tweak hotkey-clear. Maybe removing this feature entirely isn't the way to go, since it is easy to configure in-game. Some sort of additional hotkey mode (besides the built-in None/Zoom/Unit/Item) could work.

[lethosor]

It looks like this is one of the only ways to set up keybindings in PRINT_MODE:TEXT (keybinding doesn't work there). However, it currently doesn't work on OS X. Moving this to a plugin would probably be more reliable (although I'm not sure if the hotkey thread is still necessary, so it might not be trivial).

[warmist]

I vote we fix keybindings in PRINT_MODE:TEXT