New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove/replace old hotkeys-as-keybindings system #731

Open
PeridexisErrant opened this Issue Nov 5, 2015 · 6 comments

Comments

Projects
3 participants
@PeridexisErrant
Contributor

PeridexisErrant commented Nov 5, 2015

It made sense when DFHack was young and didn't have the keybinding command.

These days, it's cruft and with the number of commands available it's increasingly likely to be triggered by accident, by someone who names their burrow something like "points", "lever", "source", "liquids", autofarm"...

We just don't need it and keeping such an old feature around isn't helping anyone.

@warmist

This comment has been minimized.

Member

warmist commented Nov 5, 2015

Yes :)

@lethosor lethosor added this to the 0.40.24-r5 milestone Nov 5, 2015

@lethosor lethosor added the idea label Nov 5, 2015

@lethosor lethosor modified the milestones: 0.40.24-r5, 0.40.24-r6 Nov 26, 2015

@lethosor lethosor modified the milestones: 0.42.xx-r1, 0.42.xx-r2 Dec 18, 2015

@PeridexisErrant

This comment has been minimized.

Contributor

PeridexisErrant commented Mar 15, 2016

Whoever takes out this code should also remove the note about it in the docs here.

@lethosor

This comment has been minimized.

Member

lethosor commented Mar 15, 2016

Yeah, I tried doing this at one point, but I ran into a bunch of older code that was more complicated to remove.
From what I can tell, bindings like F1@dwarfmode should be equivalent, so we might as well get rid of the old system.

@lethosor lethosor modified the milestones: 0.42.06-r2, 0.42.06-r3 May 10, 2016

@lethosor lethosor modified the milestones: 0.43.05-r1, 0.43.05-r2 Jul 14, 2016

@lethosor

This comment has been minimized.

Member

lethosor commented May 17, 2017

I did run into someone using this (intentionally) on Reddit, which was the inspiration for tweak hotkey-clear. Maybe removing this feature entirely isn't the way to go, since it is easy to configure in-game. Some sort of additional hotkey mode (besides the built-in None/Zoom/Unit/Item) could work.

@lethosor lethosor changed the title from Remove old hotkeys-as-keybindings system to Remove/replace old hotkeys-as-keybindings system Jun 3, 2017

@lethosor lethosor added this to To Do in 0.43.05-r2 Jun 3, 2017

@lethosor

This comment has been minimized.

Member

lethosor commented Jun 8, 2017

It looks like this is one of the only ways to set up keybindings in PRINT_MODE:TEXT (keybinding doesn't work there). However, it currently doesn't work on OS X. Moving this to a plugin would probably be more reliable (although I'm not sure if the hotkey thread is still necessary, so it might not be trivial).

@warmist

This comment has been minimized.

Member

warmist commented Jun 8, 2017

I vote we fix keybindings in PRINT_MODE:TEXT

lethosor added a commit that referenced this issue Jun 9, 2017

@lethosor lethosor modified the milestones: 0.43.05-r2, 0.43.05-r3 Jul 11, 2017

@lethosor lethosor removed this from the 0.43.05-r2 milestone Jul 11, 2017

@lethosor lethosor modified the milestones: 0.43.05-r3, 0.44.x-r2 Nov 24, 2017

@lethosor lethosor removed this from the 0.44.05-r2 milestone Feb 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment