Fix gui/notify up for adventure mode #1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix wildlife showing up as a notification even though they're part of your party
myk002
reviewed
Jun 27, 2024
myk002
reviewed
Jun 28, 2024
I'm not thrilled that there is no keyboard control for the notification panel, but I think removing the Enter key handling is absolutely the right thing to do. maybe we can use Alt-up/down for scrolling and alt-left/right for zooming once those keys are available. |
Co-authored-by: Myk <myk.taylor@gmail.com>
…hack-scripts into fix-notify-adv
myk002
reviewed
Jun 29, 2024
myk002
approved these changes
Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix gui/notify eating the Enter input for adventure mode
Fix wildlife showing up as a notification even though they're part of your party