Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate unimplemented settings and update quickfort documentation #173

Merged
merged 3 commits into from Aug 4, 2020
Merged

Deprecate unimplemented settings and update quickfort documentation #173

merged 3 commits into from Aug 4, 2020

Conversation

myk002
Copy link
Member

@myk002 myk002 commented Aug 3, 2020 •
edited

DFHack/dfhack#499

  • deprecate the force_interactive_build setting since I'm not sure how or when I would implement such a feature, and I don't want the setting to cause confusion
  • update the help docs
  • handle deprecated settings, type check settings when they are set, and pretty-print the settings list
  • clarify the wording in the list output for cursor start comments

@myk002
change wording of cursor comment in quickfort list
61b9352 
don't use the wording 'place cursor' since it can be confused with the place mode
@myk002
update docs, remove unimplemented settings
f36f16c 
also type checking for settings and better settings listing format
@lethosor lethosor merged commit 4d3eb3d into DFHack:quickfort Aug 4, 2020
@myk002 myk002 deleted the quickfort_documentation branch August 4, 2020 06:40
@lethosor lethosor added this to In progress in 0.47.04-r3 via automation Sep 14, 2020
@lethosor lethosor moved this from In progress to Done in 0.47.04-r3 Sep 14, 2020
@myk002 myk002 mentioned this pull request May 23, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lethosor lethosor lethosor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
0.47.04-r3
  
Done
Milestone
No milestone
2 participants
@myk002 @lethosor