FIX: handle "flour" food type preference. #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lethosor
approved these changes
Nov 18, 2020
| @@ -297,6 +297,7 @@ local preference_functions = { | |||
| local item_subtype = -1 | |||
| local food_mat_index = mat_info.material.food_mat_index | |||
| -- FIXME: is fish missing? Apparently it's considered meat... | |||
| -- FIXME: maybe automatize this process instead of using a chain of if-elseif statements? | |||
There was a problem hiding this comment.
Enums defined in DF-structures support attributes, which could allow mapping organic_mat_category items to item_type items, if the mapping defined here is general enough. (If it only makes sense in this script, or if you want to deliberately exclude some entries, defining a table in this script could also make sense.)
Example of attributes: https://github.com/DFHack/df-structures/blob/dd8b9335007941c3aea27474b0a08ba31f6bc97f/df.job-types.xml#L21
organic_mat_category definition: https://github.com/DFHack/df-structures/blob/dd8b9335007941c3aea27474b0a08ba31f6bc97f/df.materials.xml#L454
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small correction fixes a problem when adding flours as a food type preference to a unit.
Relevant forum post:
http://www.bay12forums.com/smf/index.php?topic=110027.msg8205633#msg8205633