Release: develop -> main#3847
Merged
Merged
Conversation
…ssed (#3845) When compliance staff set amlCheck to Pass via the generic update endpoint (PUT /buyCrypto/:id, PUT /buyFiat/:id), priceDefinitionAllowedDate was only persisted if it was explicitly included in the payload. Unlike the automatic AML pass (AmlHelperService) and manualPassAmlCheck, the update path did not couple the date to the Pass transition, leaving transactions stuck in status Created with amlCheck=Pass and a null priceDefinitionAllowedDate. Couple priceDefinitionAllowedDate to the Pass transition in both BuyCryptoService.update and BuyFiatService.update, mirroring the automatic pass behaviour. An explicit payload value still takes precedence.
github-actions
Bot
requested review from
TaprootFreak and
davidleomay
as code owners
#3846) * fix(auth): brand login mail by login source instead of account history resolveMailWallet forced any account ever linked to a preferred wallet (RealUnit) onto RealUnit branding, so logins via app.dfx.swiss received RealUnit confirmation mails. signInByMail now resolves the originating login wallet once and passes it explicitly, so branding follows the login source (DFX vs. RealUnit). * fix(auth): always resolve a concrete login wallet for mail branding guarantees branding follows the login source even when an unknown wallet name is passed, so it never falls back to the account-history override
TaprootFreak
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic Release PR
This PR was automatically created after changes were pushed to develop.
Commits: 1 new commit(s)
Checklist