New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Similar typedefs for parametric shape #1462
Conversation
- Use of delete/default directives for constructors/destructors - Add copy constructors
Yes, I prepare an IPOL demo that evaluate discrete estimators on all
digitizations of an object, up to a translation. Of course, this demo
is based on DGtal ;), and mainly uses shapes and estimators.
|
@akrah cool! I thought that these are mainly used for examples and demos, though. So, I was a bit surprised to see PR regarding them :-) |
@copyme I suppose it was probably the case because PRs I make are mostly about difficulties to homogenize shapes and estimators concepts in order to use generalization in code using them. |
@akrah I agree. During my masters Yukiko asked us to write some experiments in DGtal concerning estimators. Unifying this is a marvelous idea, at least from a student stand point :D |
- Simplify some methods computing parameter, derived, tangent, etc. by suppressing useless variables and defining constants - Fix some comparisons to 0 with an isAlmostEqual method - Add some const directives and change copied parameters by references
Thx @akrah , could tou please add a Changelog entry ? |
Done @dcoeurjo! |
thanks @akrah for the cleanup ! |
Similar typedefs for parametric shape
PR Description
This PR:
This PR also:
Checklist
cmake
mode (otherwise, Travis C.I. will fail).