Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface mesh, a generic representation for polygonal surfaces #1503

Merged
merged 45 commits into from Sep 3, 2020

Conversation

JacquesOlivierLachaud
Copy link
Member

@JacquesOlivierLachaud JacquesOlivierLachaud commented Jul 16, 2020

PR Description

This PR provides classes to represent and process generic polygonal faces, whether manifold or non manifold.

Checklist

  • Unit-test of your feature with Catch.
  • Doxygen documentation of the code completed (classes, methods, types, members...)
  • Documentation module page added or updated.
  • New entry in the ChangeLog.md added.
  • No warning raised in Debug cmake mode (otherwise, Travis C.I. will fail).
  • All continuous integration tests pass (Travis & appveyor)

@kerautret
Copy link
Member

kerautret commented Sep 2, 2020

@JacquesOlivierLachaud I also make a small PR on your branch with an add if you miss it (else no pb I will PR on master later)

@kerautret
Copy link
Member

kerautret commented Sep 2, 2020

@JacquesOlivierLachaud
Copy link
Member Author

JacquesOlivierLachaud commented Sep 2, 2020

There seems to be an unrelated issue in Travis CI, which requires a modification in Travis CI config. Has Eigen moved to another repository (here bitbucket, but perhaps Eigen has moved to github ?).

@dcoeurjo
Copy link
Member

dcoeurjo commented Sep 2, 2020

@phcerdan has a pending PR for the Eigen URL. On his PR, there is another issue (timeout on macOS bots) but let me check if I can merge it so that you can benefit from it

@dcoeurjo
Copy link
Member

dcoeurjo commented Sep 2, 2020

@phcerdan ’s PR has just been merged. Should be easier now

@JacquesOlivierLachaud
Copy link
Member Author

JacquesOlivierLachaud commented Sep 2, 2020

Cool ! It seems to work now !

@dcoeurjo
Copy link
Member

dcoeurjo commented Sep 3, 2020

Thanks @JacquesOlivierLachaud for the edits!
that's perfect.

@dcoeurjo dcoeurjo self-requested a review Sep 3, 2020
@dcoeurjo dcoeurjo merged commit 81fdf92 into DGtal-team:master Sep 3, 2020
2 checks passed
@JacquesOlivierLachaud JacquesOlivierLachaud deleted the SimpleMesh branch Sep 3, 2020
dcoeurjo added a commit that referenced this pull request Oct 2, 2020
Surface mesh, a generic representation for polygonal surfaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants