Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing old catch.hpp snapshot, Fixing DGtal on Apple M1 #1590

Merged
merged 4 commits into from Jul 30, 2021
Merged

Removing old catch.hpp snapshot, Fixing DGtal on Apple M1 #1590

merged 4 commits into from Jul 30, 2021

Conversation

dcoeurjo
Copy link
Member

@dcoeurjo dcoeurjo commented Jul 28, 2021 •
edited

PR Description

Checklist

  • Unit-test of your feature with Catch.
  • Doxygen documentation of the code completed (classes, methods, types, members...)
  • Documentation module page added or updated.
  • New entry in the ChangeLog.md added.
  • No warning raised in Debug cmake mode (otherwise, Travis C.I. will fail).
  • All continuous integration tests pass (Travis & appveyor)

@dcoeurjo dcoeurjo mentioned this pull request Jul 28, 2021
Closed
@dcoeurjo dcoeurjo requested a review from kerautret July 30, 2021 11:13
kerautret
kerautret reviewed Jul 30, 2021
View reviewed changes
Copy link
Member

@kerautret kerautret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine for mes thanks

examples/doc-examples/CMakeLists.txt Outdated Show resolved Hide resolved
examples/doc-examples/CMakeLists.txt Outdated Show resolved Hide resolved
@dcoeurjo @kerautret
Update examples/doc-examples/CMakeLists.txt
dcf8c22 
Co-authored-by: Bertrand Kerautret <bertrand.kerautret@univ-lyon2.fr>
@dcoeurjo
Copy link
Member Author

Thx @kerautret

@dcoeurjo dcoeurjo merged commit d45d6eb into master Jul 30, 2021
@dcoeurjo dcoeurjo deleted the Catch2M1 branch July 30, 2021 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kerautret kerautret kerautret approved these changes

Assignees
No one assigned
Labels
ready for review 👍
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dcoeurjo @kerautret