Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Longvol in GenerucWriter and tests #1610

Merged
merged 2 commits into from Oct 8, 2021
Merged

fix Longvol in GenerucWriter and tests #1610

merged 2 commits into from Oct 8, 2021

Conversation

kerautret
Copy link
Member

@kerautret kerautret commented Oct 7, 2021 •
edited

PR Description

your description here

Checklist

Small PR to fix longvol write from genericWriter and add test.

  • Unit-test of your feature with Catch.
  • Doxygen documentation of the code completed (classes, methods, types, members...)
  • Documentation module page added or updated.
  • New entry in the ChangeLog.md added.
  • No warning raised in Debug cmake mode (otherwise, C.I. will fail).
  • All continuous integration tests pass (Github Actions & appveyor)

@dcoeurjo dcoeurjo self-requested a review October 8, 2021 06:51
dcoeurjo
dcoeurjo approved these changes Oct 8, 2021
View reviewed changes
Copy link
Member

@dcoeurjo dcoeurjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thx

@kerautret kerautret merged commit e9ec96c into DGtal-team:master Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcoeurjo dcoeurjo dcoeurjo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kerautret @dcoeurjo