Skip to content

Fixing CGAL 6.0 breaking change. - #1745

Merged
dcoeurjo merged 3 commits into
masterfrom
cgal6.0
Oct 2, 2024
Merged

Fixing CGAL 6.0 breaking change.#1745
dcoeurjo merged 3 commits into
masterfrom
cgal6.0

Conversation

@dcoeurjo

@dcoeurjo dcoeurjo commented Oct 1, 2024

Copy link
Copy Markdown
Member

PR Description

CGAL 6.0 has no CGAL_USE_FILE anymore.

Checklist

  • Unit-test of your feature with Catch.
  • Doxygen documentation of the code completed (classes, methods, types, members...)
  • Documentation module page added or updated.
  • New entry in the ChangeLog.md added.
  • No warning raised in Debug mode.
  • All continuous integration tests pass (Github Actions)

@dcoeurjo

dcoeurjo commented Oct 1, 2024

Copy link
Copy Markdown
Member Author

@JacquesOlivierLachaud @kerautret, could you please test the build of this PR activating CGAL on your system ?

@kerautret

Copy link
Copy Markdown
Member

@JacquesOlivierLachaud @kerautret, could you please test the build of this PR activating CGAL on your system ?

Thanks I look it, updating CGal from brew in progress...

@kerautret kerautret left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks perfect on my Mac, and DGtalTools also checked with CGal based tools well complied.👏🏻

@dcoeurjo

dcoeurjo commented Oct 2, 2024

Copy link
Copy Markdown
Member Author

ok thanks, merging

@dcoeurjo
dcoeurjo merged commit 90153d1 into master Oct 2, 2024
@dcoeurjo
dcoeurjo deleted the cgal6.0 branch October 2, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants