-
Notifications
You must be signed in to change notification settings - Fork 4
Changed Historicizing GAMES index.qmd. Deleted GAMES-program.pdf in favor of a html table with accordion abstracts of presentations. #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…for Historicizing G.A.M.E.S. event
… pdf. deleted GAMES-program.pdf
WalkthroughThe update replaces a placeholder and embedded PDF in a conference program webpage with a fully detailed, styled HTML schedule. The new content features a multi-day, interactive program layout, including tables for each day, session details, collapsible abstracts, and custom CSS styling, all integrated within the existing tab structure. Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (4)
content/projects/ch-ludens/20250911-historicizing-GAMES/index.qmd (4)
101-146: Consider externalizing CSS and removing German comments.The inline CSS styling works but could be better organized. Additionally, there are German comments in the CSS that should be in English for consistency.
Consider moving the CSS to an external stylesheet or at least to a
<style>block in the document head:-<style> - table { - width: 100%; - border-collapse: collapse; - } - th, td { - padding: 8px 12px; - border: 1px solid #ccc; - vertical-align: top; - text-align: left; - } - details { - margin: 0; - } - summary { - cursor: pointer; - font-weight: normal; - margin: 0; - padding: 0; - } - details summary { - font-weight: 400 !important; /* "normal" mit !important zum Überschreiben */ - color: #333; /* optional, etwas weniger kontrastreich */ -} - -details p { - font-weight: 300; /* leichter als normal */ - color: #555; /* optional, etwas dezenter */ - margin-top: 6px; -} - - - /* Helle Hintergrundfarben für einzelne Zeilen */ - .highlight-lightblue { - background-color: #e6f0ff; /* sehr helles Blau */ - } - .highlight-lightgreen { - background-color: #e6ffe6; /* sehr helles Grün */ - } - .highlight-yellow { - background-color:rgb(250, 230, 163); /* sehr helles Gelb */ - } - .highlight-lightyellow { - background-color: #fff9e6; /* sehr helles Gelb */ - } -</style> +<style> + table { + width: 100%; + border-collapse: collapse; + } + th, td { + padding: 8px 12px; + border: 1px solid #ccc; + vertical-align: top; + text-align: left; + } + details { + margin: 0; + } + summary { + cursor: pointer; + font-weight: normal; + margin: 0; + padding: 0; + } + details summary { + font-weight: 400 !important; /* normal weight with !important to override */ + color: #333; /* slightly less contrast */ + } + + details p { + font-weight: 300; /* lighter than normal */ + color: #555; /* slightly subdued */ + margin-top: 6px; + } + + /* Light background colors for individual rows */ + .highlight-lightblue { + background-color: #e6f0ff; /* very light blue */ + } + .highlight-lightgreen { + background-color: #e6ffe6; /* very light green */ + } + .highlight-yellow { + background-color: rgb(250, 230, 163); /* very light yellow */ + } + .highlight-lightyellow { + background-color: #fff9e6; /* very light yellow */ + } +</style>
148-165: Improve table accessibility with proper structure.The table structure is good but could benefit from better accessibility features.
Consider adding a caption and more descriptive headers:
<table> + <caption>Conference Program - Day 0 (September 10, 2025)</caption> <thead> <tr> - <th class="highlight-lightblue">When</th> - <th class="highlight-lightblue">What</th> - <th class="highlight-lightblue">Where</th> + <th class="highlight-lightblue" scope="col">Time</th> + <th class="highlight-lightblue" scope="col">Activity</th> + <th class="highlight-lightblue" scope="col">Location</th> </tr> </thead>
230-232: Complete the missing abstract content.The abstract for Ayşe Bayrakci Gulyuz's presentation is incomplete with only "Coming soon..." as content.
This presentation appears to be missing its abstract content. Would you like me to help track this as a TODO item or create an issue to ensure the abstract is added before the conference?
367-369: Clarify the undefined activity.The program shows "Activity (TBD)" which needs to be defined.
Panel 4 contains an undefined activity marked as "TBD". This should be clarified before the conference program is finalized. Would you like me to help create a tracking issue for this?
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
content/projects/ch-ludens/20250911-historicizing-GAMES/games-Program.pdfis excluded by!**/*.pdf
📒 Files selected for processing (1)
content/projects/ch-ludens/20250911-historicizing-GAMES/index.qmd(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Build, Optimize, and Upload Artifacts
🔇 Additional comments (1)
content/projects/ch-ludens/20250911-historicizing-GAMES/index.qmd (1)
169-505: Excellent implementation of accessible and interactive program layout.The HTML table structure with collapsible abstracts provides an excellent user experience. The styling is consistent, the content is well-organized, and the use of
<details>elements makes the abstracts accessible while keeping the layout clean.Key strengths:
- Proper semantic HTML structure
- Consistent styling and color coding
- Accessible collapsible abstracts
- Clear time/location information
- Professional presentation format
Pull request
Proposed changes
Types of changes
Checklist
Summary by CodeRabbit