Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Search page #39

Closed
wants to merge 12 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

wejendorp commented May 18, 2012

TODO
Figure out weird Document error.

DONE

  • Using a new json lib, and moved serialization into an AppModel class.
  • CreateDocument logic for full-text search and search controller.

Template
Cleaner JS, but no results to display.

Contributor

wejendorp commented on a8d557b May 18, 2012

I accidentally commited the to_dict twice, both as a model and in util.. I think it should work without being called explicitly by naming it dict instead of to_dict.. awaiting further trials.

Contributor

jensraaby replied May 20, 2012

Did you see http://googleappengine.blogspot.com/2012/05/looking-for-search-find-it-on-google.html
It's from 12 days ago so quite a new and experimental API. Seems to work similarly to Apache lucene in that you have to build a document store for searching.
They have example code here: http://code.google.com/p/google-app-engine-samples/source/browse/trunk/search/python/search_demo.py

@jensraaby jensraaby commented on an outdated diff May 20, 2012

controllers/searchController.py
@@ -0,0 +1,64 @@
+""" Controller for managing the different kinds of search """
+from util import AppRequestHandler
+from models.study import Study, Snp, Gene, Disease
+
+class SNPSearch(AppRequestHandler):
+ """ Handle SNP searches """
+ def get(self, query):
+ """ Request via GET = single """
+ snp = None
+ if query != "":
+ snp = Snp.gql('WHERE snpid = :1', query)
@jensraaby

jensraaby May 20, 2012

Contributor

There seems to be duplication between this method and the ones in the other xxxSearch classes - could it be shared?

Merge pull request #40 from DIKU-DevStudio/remove_dead_links
A few template changes. Removed a couple of dead links. We might need to...
Contributor

jensraaby commented May 20, 2012

I like the search page in general, but if I type in plain text I get an alert and it doesn't search. Is that intended? If you can search for a disease it will probably be in plain text

Contributor

wejendorp commented May 20, 2012

Oh right, yea it is still a work in progress, I totally forgot that the old JS function is still used for form submit.

Contributor

wejendorp commented May 21, 2012

Can you try and test the Text search pages after populating the database and see if you get the same error? That is, template not found error for the sub-categories on http://localhost:8080/_ah/admin/search
Doing a rebase now.

Is this neat enough @jensraaby ? ^^

Contributor

paddie commented May 21, 2012

Wow, you really need to rebase :)

I'm testing as well..

Contributor

paddie commented May 21, 2012

And yes, also getting the error.

wejendorp added some commits May 18, 2012

SNP search results working.. but only for exact matches
Renamed util to Util to fix error 500 with util import in google lib.
Implemented documents and search logic, but having issues with result…
…s and the backend: http://localhost:8080/_ah/admin/search_index
Contributor

wejendorp commented May 22, 2012

Note to self: Try remove default template fallback from requesthandler.

wejendorp added some commits May 22, 2012

Contributor

wejendorp commented May 23, 2012

I am an idiot and did the fix of search on the development branch.

@wejendorp wejendorp closed this May 23, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment