Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency of case in section II, 5.3.6 #316

Closed
karinbredenberg opened this issue Mar 11, 2019 · 4 comments
Closed

Consistency of case in section II, 5.3.6 #316

karinbredenberg opened this issue Mar 11, 2019 · 4 comments
Assignees
Labels
Proof Read Issues to be dealt with in a final proof read. Review comment This issue originates from the review process Typos and text enhancements Issues reporting typos and text enhancments which dont change the meaning of the text

Comments

@karinbredenberg
Copy link
Contributor

Sometimes the controlled value of folder names starts with an upper-case letter, sometimes with a lower-case letter. Should be unified.

Section: II, 5.3.6
Text: The metadata division (div) element in the package uses the value “Metadata” as the value for the attribute LABEL.

@karinbredenberg karinbredenberg added Typos and text enhancements Issues reporting typos and text enhancments which dont change the meaning of the text Review comment This issue originates from the review process labels Mar 11, 2019
@carlwilson carlwilson added this to the CSIP version 2.0 milestone Mar 22, 2019
@carlwilson carlwilson changed the title Unification in section II, 5.3.6 Consistency of case in section II, 5.3.6 Mar 22, 2019
@koit
Copy link
Contributor

koit commented Apr 30, 2019

These are present in:

  • CSIPSTR rules 5-11, 13, 15, 16
  • CSIP rules 48, 60, 64, 66 etc.
  • VocabularyFileGrpAndStructMapDivisionLabel in DILCISVocabulariesIP.xml

@carlwilson
Copy link
Collaborator

Will be making vocabulary case consistent in a late review sweep, assisted by an automated search with manually curated replace.

@carlwilson
Copy link
Collaborator

Along side case consistency checks (names, etc.) and typography consistency (e.g. use of <mets> , etc.) we should document the decisions (briefly) as an elementary style guide.

@carlwilson carlwilson added the Proof Read Issues to be dealt with in a final proof read. label May 10, 2019
@carlwilson carlwilson modified the milestones: CSIP version 2.0, CSIP v2.0.4 Apr 30, 2020
@karinbredenberg
Copy link
Contributor Author

This will require a major update in not only the CSIP but also in the validations tools and so on. Its on the agenda for a revsion further on where the change will be all in lower case and spaces are replaced with underscore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Proof Read Issues to be dealt with in a final proof read. Review comment This issue originates from the review process Typos and text enhancements Issues reporting typos and text enhancments which dont change the meaning of the text
Projects
None yet
Development

No branches or pull requests

4 participants