From 738a697c22b66e0d6fe298f2f18a70ebb607c718 Mon Sep 17 00:00:00 2001 From: Simon Fayer Date: Fri, 10 Jul 2026 19:17:44 +0100 Subject: [PATCH] fix: Drop extra escaping in TransformationDB --- .../TransformationSystem/DB/TransformationDB.py | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/src/DIRAC/TransformationSystem/DB/TransformationDB.py b/src/DIRAC/TransformationSystem/DB/TransformationDB.py index 06bad1d929b..07830d935bf 100755 --- a/src/DIRAC/TransformationSystem/DB/TransformationDB.py +++ b/src/DIRAC/TransformationSystem/DB/TransformationDB.py @@ -533,10 +533,6 @@ def __addAdditionalTransformationParameter(self, transID, paramName, paramValue, res = self._update(req, args=(transID, paramName), conn=connection) if not res["OK"]: return res - res = self._escapeString(paramValue) - if not res["OK"]: - return S_ERROR("Failed to parse parameter value") - paramValue = res["Value"] paramType = "StringType" if isinstance(paramValue, int): paramType = "IntType" @@ -1158,10 +1154,6 @@ def deleteTransformationMetaQuery(self, transName, queryType, author="", connect return res connection = res["Value"]["Connection"] transID = res["Value"]["TransformationID"] - res = self._escapeString(queryType) - if not res["OK"]: - return S_ERROR("Failed to parse the transformation query type") - queryType = res["Value"] req = "DELETE FROM TransformationMetaQueries WHERE TransformationID=%s AND QueryType=%s" res = self._update(req, args=(transID, queryType), conn=connection) if not res["OK"]: @@ -1186,13 +1178,9 @@ def getTransformationMetaQuery(self, transName, queryType, connection=False): return res connection = res["Value"]["Connection"] transID = res["Value"]["TransformationID"] - res = self._escapeString(queryType) - if not res["OK"]: - return S_ERROR("Failed to parse the transformation query type") - queryType = res["Value"] req = "SELECT MetaDataName,MetaDataValue,MetaDataType FROM TransformationMetaQueries" - req += f" WHERE TransformationID={transID} AND QueryType={queryType}" - res = self._query(req, conn=connection) + req += " WHERE TransformationID=%s AND QueryType=%s" + res = self._query(req, args=(transID, queryType), conn=connection) if not res["OK"]: return res queryDict = {}