Fix memory leak, cleanup

falkTX · falkTX · commit fdfd21f263b4 · 2021-09-19T14:39:42.000+01:00
Signed-off-by: falkTX &lt;falktx@falktx.com&gt;
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -255,7 +255,7 @@ jobs:
       - name: Build plugins
         env:
           CFLAGS: -g
-          CXXFLAGS: -g
+          CXXFLAGS: -g -DDPF_ABORT_ON_ERROR
           LDFLAGS: -static-libgcc -static-libstdc++
         run: |
           make features
diff --git a/dpf b/dpf
@@ -1 +1 @@
-Subproject commit e44a908375610d7f46b507532b4602c9f89f085a
+Subproject commit 9aec1687c8ef5304efd8da6a65bdd1d0913fa612
diff --git a/plugins/bitcrush/Makefile b/plugins/bitcrush/Makefile
@@ -29,13 +29,10 @@ BUILD_CXX_FLAGS += -Wno-unused-parameter
 # --------------------------------------------------------------
 # Enable all possible plugin types
 
-ifeq ($(HAVE_JACK),true)
 TARGETS += jack
-endif
-
 TARGETS += ladspa
 TARGETS += lv2_dsp
-TARGETS += vst
+TARGETS += vst2
 
 all: $(TARGETS)
 
diff --git a/plugins/common/gen_dsp/genlib.cpp b/plugins/common/gen_dsp/genlib.cpp
@@ -221,6 +221,7 @@ void genlib_data_release(t_genlib_data *b) {
 		genlib_sysmem_freeptr(self->info.data);
 		self->info.data = 0;
 	}
+	genlib_sysmem_freeptr(self);
 }
 
 long genlib_data_getcursor(t_genlib_data *b) {
diff --git a/plugins/freeverb/Makefile b/plugins/freeverb/Makefile
@@ -29,13 +29,10 @@ BUILD_CXX_FLAGS += -Wno-unused-parameter
 # --------------------------------------------------------------
 # Enable all possible plugin types
 
-ifeq ($(HAVE_JACK),true)
 TARGETS += jack
-endif
-
 TARGETS += ladspa
 TARGETS += lv2_dsp
-TARGETS += vst
+TARGETS += vst2
 
 all: $(TARGETS)
 
diff --git a/plugins/gigaverb/Makefile b/plugins/gigaverb/Makefile
@@ -29,13 +29,10 @@ BUILD_CXX_FLAGS += -Wno-unused-parameter
 # --------------------------------------------------------------
 # Enable all possible plugin types
 
-ifeq ($(HAVE_JACK),true)
 TARGETS += jack
-endif
-
 TARGETS += ladspa
 TARGETS += lv2_dsp
-TARGETS += vst
+TARGETS += vst2
 
 all: $(TARGETS)
 
diff --git a/plugins/pitchshift/Makefile b/plugins/pitchshift/Makefile
@@ -29,13 +29,10 @@ BUILD_CXX_FLAGS += -Wno-unused-parameter
 # --------------------------------------------------------------
 # Enable all possible plugin types
 
-ifeq ($(HAVE_JACK),true)
 TARGETS += jack
-endif
-
 TARGETS += ladspa
 TARGETS += lv2_dsp
-TARGETS += vst
+TARGETS += vst2
 
 all: $(TARGETS)
 

Original file line number	Diff line number	Diff line change
`@@ -221,6 +221,7 @@ void genlib_data_release(t_genlib_data *b) {`
`221`	`221`	`genlib_sysmem_freeptr(self->info.data);`
`222`	`222`	`self->info.data = 0;`
`223`	`223`	`}`
	`224`	`+ genlib_sysmem_freeptr(self);`
`224`	`225`	`}`
`225`	`226`
`226`	`227`	`long genlib_data_getcursor(t_genlib_data *b) {`