Fix infinite loop when receiving midi message over 4 bytes in size

falkTX · falkTX · commit 0e999f34e128 · 2022-10-30T19:52:04.000Z
Signed-off-by: falkTX &lt;falktx@falktx.com&gt;
diff --git a/plugins/Nekobi/DistrhoPluginNekobi.cpp b/plugins/Nekobi/DistrhoPluginNekobi.cpp
@@ -373,13 +373,12 @@ void DistrhoPluginNekobi::run(const float**, float** outputs, uint32_t frames, c
             fSynth.nugget_remains = XSYNTH_NUGGET_SIZE;
 
         /* process any ready events */
-        while (curEventIndex < midiEventCount && framesDone == midiEvents[curEventIndex].frame)
+        for (; curEventIndex < midiEventCount && framesDone == midiEvents[curEventIndex].frame; ++curEventIndex)
         {
             if (midiEvents[curEventIndex].size > MidiEvent::kDataSize)
                 continue;
 
             nekobee_handle_raw_event(&fSynth, midiEvents[curEventIndex].size, midiEvents[curEventIndex].data);
-            curEventIndex++;
         }
 
         /* calculate the sample count (burstSize) for the next nekobee_voice_render() call to be the smallest of:

Original file line number	Diff line number	Diff line change
`@@ -373,13 +373,12 @@ void DistrhoPluginNekobi::run(const float, float outputs, uint32_t frames, c`
`373`	`373`	`fSynth.nugget_remains = XSYNTH_NUGGET_SIZE;`
`374`	`374`
`375`	`375`	`/* process any ready events */`
`376`		`- while (curEventIndex < midiEventCount && framesDone == midiEvents[curEventIndex].frame)`
	`376`	`+ for (; curEventIndex < midiEventCount && framesDone == midiEvents[curEventIndex].frame; ++curEventIndex)`
`377`	`377`	`{`
`378`	`378`	`if (midiEvents[curEventIndex].size > MidiEvent::kDataSize)`
`379`	`379`	`continue;`
`380`	`380`
`381`	`381`	`nekobee_handle_raw_event(&fSynth, midiEvents[curEventIndex].size, midiEvents[curEventIndex].data);`
`382`		`- curEventIndex++;`
`383`	`382`	`}`
`384`	`383`
`385`	`384`	`/* calculate the sample count (burstSize) for the next nekobee_voice_render() call to be the smallest of:`