Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kinks in profiles #630

Closed
MarAlder opened this issue Mar 9, 2020 · 6 comments
Closed

Kinks in profiles #630

MarAlder opened this issue Mar 9, 2020 · 6 comments
Milestone

Comments

@MarAlder
Copy link
Collaborator

MarAlder commented Mar 9, 2020

@rainman110 has added a TiGL feature which accounts for kinks in profiles. The proposal #629 is merged to develop (see 3694d8f). Please have a look at the new kinks and parameterMap elements in the curvePointListXYZType:

76216459-e9384800-6210-11ea-9d5d-40fb38a4574f

Let us know if you have any comments so that I can plan the implementation of the schema modification in the next CPACS release.

@MarAlder MarAlder added this to the cpacs 3.3 milestone Mar 9, 2020
@ProgramAlarm1202
Copy link

ProgramAlarm1202 commented Mar 10, 2020

Would it make sense to extend the definition of kinks in profiles #629 to guide curves as well?
The rXDirection element could similarly be extended with kinks and parameterMap elements. The implementation in TiGL DLR-SC/tigl#659 would be probably (hopefully) not that different.

@rainman110
Copy link
Member

@ProgramAlarm1202 It is already possible to have a kink in the guide curve AT a section. I would avoid defining additional kinks within a segment though.

@ProgramAlarm1202
Copy link

@rainman110 Good point. A limitation is that a section is always planar. But I suppose if you want a kink at a particular location, you can always insert an additional section.

@MarAlder
Copy link
Collaborator Author

More detailed information about the parameterMap: TiGL Homepage

@MarAlder MarAlder closed this as completed Oct 9, 2020
@MarAlder
Copy link
Collaborator Author

@rainman110 @joergbrech : At the stakeholder meeting the question was raised whether we use 0 or 1 indexing for the [kinks](https://www.cpacs.de/documentation/CPACS_development/html/d0271c9a-2b38-36af-5f3f-50d49dabdbda.htm) vector (because XPATH starts with index 1 and I think many TiGL functions do so as well, right?). What do you think?

@MarAlder MarAlder reopened this Mar 16, 2021
@MarAlder
Copy link
Collaborator Author

We have decided to use 1 indexing throughout CPACS (i.e., counting indices of vectors from 1). To distinguish the CPACS 3.3 schema from the TiGL 3.1 implementation (using 0 indexing) I renamed the corresponding parameters:

grafik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants