Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common nomenclature: air speed #695

Closed
MarAlder opened this issue Mar 8, 2021 · 3 comments
Closed

Common nomenclature: air speed #695

MarAlder opened this issue Mar 8, 2021 · 3 comments
Labels
breaking change This modification eliminates the compatibility of older data sets naming convention
Milestone

Comments

@MarAlder
Copy link
Collaborator

MarAlder commented Mar 8, 2021

We should try to introduce a naming convention for velocities.

Current implementations in the 3.3 beta-release are:

Decisions:

  • Should we in future distinguish between calibrated and true air speed or rely on conversion with atmospheric model?
  • Which style to use: calibratedAirSpeed, CAS, cAS or vCAS?
@MarAlder MarAlder added this to the cpacs 3.3 milestone Mar 8, 2021
@HHOPs
Copy link

HHOPs commented Mar 11, 2021

@MarAlder
Copy link
Collaborator Author

MarAlder commented Mar 11, 2021

For the symbol representation I would recommend to use the respective norms - ISO 1151-1:1988, https://www.iso.org/standard/5699.html

I have no access to this. What does the norm say?

I also got the feedback that we are writing most parameters as full names, e.g. machNumber, altitude, angleOfAttack, etc, and therefore we should also try to write velocities as calibratedAirSpeed and trueAirSpeed.

@MarAlder MarAlder added the breaking change This modification eliminates the compatibility of older data sets label Mar 16, 2021
@MarAlder
Copy link
Collaborator Author

Renamed to calibratedAirSpeed and trueAirSpeed for:

  • constraintSettingsType (missionDefinition)
  • missionSegmentEndConditionType (missionDefinition)
  • missionStartConditionType (missionDefinition)
  • flightDynamicsTrimResultType (flightDynamics analysis)
  • pointPerformanceConstraintsType (pointPerformance)
  • flightEnvelopeSpeedType (flightEnvelope)

❗ ❗ ❗ This breaks backwards compatibility, so please review carefully. However, the upper types are used within current or planned changes in the 3.3-RC.

Not changed yet for (as no reply from stakeholder and currently strongly used in the trajectory node):

  • flightPointType

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change This modification eliminates the compatibility of older data sets naming convention
Projects
None yet
Development

No branches or pull requests

2 participants