Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonization of the nomenclature #711

Closed
MarAlder opened this issue Mar 31, 2021 · 4 comments
Closed

Harmonization of the nomenclature #711

MarAlder opened this issue Mar 31, 2021 · 4 comments

Comments

@MarAlder
Copy link
Collaborator

With regard to the CPACS 3.3 release, some larger adjustments and enhancements such as aeroCases, loadCases and missionDefinitions or pointPerformances were discussed. During and after the stakeholder meetings there were some requests to harmonize the nomenclature before the official finalization. This issue will summarize the major changes:

Naming conventions:

I added the proposed development guidelines (#704) to development.md. The proposed naming conventions are applied in a common structure for analysis elements:

The figure below shows an example of a typical analysis node. A complete analysis case is summarized with case. There is no need for a plural parent element ..Cases if there exists no alternatives. In other words, if myDiscipline groups different analysis cases, a plural parent element should be applied (e.g., flightDynamics: trimCases, controllabilityCases, etc.). In addition to a uID attribute as well as the usual name (obligatory) and description (optinoal) elements, a case consists of two parts.

The first part should be labeld as specification and contains the input parameters for the corresponding analysis (since these may represent an output for other disciplines, the name input should be avoided at this point; also the term definition is a bit too imprecise). There are a few typical elements which should be reused for the specification if it makes sense. This includes an environment element of type environmentType, which provides an atmosphericModel and a corresponding deltaTemperature. A node named configuration of type configurationType provides a uID reference to predefined configurations as well as additional individual control devices that can be superposed to this configuration. This set of inputs might be further enriched by own parameters such as uID references to existing components or individual parameters based on the simple baseTypes.

The second part contains the actual analysis data and its name may depending on the discipline (myResults used as a placeholder).

grafik

The naming conventions and harmonization of analysis elements will affect the following implementations:

aeroCases

before:
grafik

after:
grafik

flight/groundLoadCases

before:
grafik

after:
grafik

aeroMaps (will not be part of CPACS 3.3!)

We also propose to harmonize the aeroMaps in a future release:

now:
grafik

future:
grafik

Summary of analyses nodes

So I would say it looks really harmonic:
grafik

missionDefinitions

before:
grafik

after:
grafik

pointPerformances

before:
grafik

after:
grafik

@MarAlder MarAlder added this to the cpacs 3.3 milestone Mar 31, 2021
@MarAlder MarAlder pinned this issue Mar 31, 2021
@ErwinMoerland
Copy link

Hi @MarAlder, looks good and makes the structure much more clear! I am very happy with the creation and application of the common nomenclature as well as with the more harmonized common structure of analysis node contents .

One thing to consider to further harmonize the <analysis> node contents:

"The second part contains the actual analysis data and its name may depending on the discipline (myResults used as a placeholder)."

for myResults we now have:

<aeroCase> -> <aeroData>
<flightLoadCase>, <groundLoadCase>, <crashLoadCase> -> <loads>
<aeroMap> -> <aeroPerformanceMap>, <aeroLimitsMap>

should we provide a hint on naming conventions for the myData node? We can distinguish two kinds of result nodes: data and maps. Then we could have the following:

<aeroCase> -> <aeroData>
<flightLoadCase>, <groundLoadCase>, <crashLoadCase> -> <loadData>
<aeroMap> -> <aeroPerformanceMap>, <aeroLimitsMap>

i.e.: the xxxData and xxxMap represent the base nodes for the actual analysis data. This convention could be used throughout the complete <analysis> node

@MarAlder
Copy link
Collaborator Author

MarAlder commented Apr 1, 2021

Good suggestion!

@MarAlder
Copy link
Collaborator Author

MarAlder commented Apr 8, 2021

Implemented via e485289 (see development.md)

grafik

@MarAlder
Copy link
Collaborator Author

MarAlder commented Jun 3, 2021

No feedback; so I assume everything is harmonic now :)

@MarAlder MarAlder closed this as completed Jun 3, 2021
@MarAlder MarAlder unpinned this issue Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants