New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel parts/quits with reasons should be able to have a different format than those without #739

Open
ShaneMcC opened this Issue Dec 31, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@ShaneMcC
Member

ShaneMcC commented Dec 31, 2016

Previously we had channelPart and channelPartReason formatters that allowed this, now we just have ChannelPartEvent

@ShaneMcC

This comment has been minimized.

Show comment
Hide comment
@ShaneMcC

ShaneMcC Dec 31, 2016

Member

This also applies to channelKick/channelKickReason

Member

ShaneMcC commented Dec 31, 2016

This also applies to channelKick/channelKickReason

@csmith

This comment has been minimized.

Show comment
Hide comment
@csmith

csmith Dec 31, 2016

Member

I think the easiest way to do this is to allow very simple conditions for boolean fields (so the event will have a hasReason() method, and the formatter can define one option for each)

Member

csmith commented Dec 31, 2016

I think the easiest way to do this is to allow very simple conditions for boolean fields (so the event will have a hasReason() method, and the formatter can define one option for each)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment