Display change log in admin for superusers #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quantum5
changed the title
quantum5
requested changes
Apr 16, 2019
judge/admin/interface.py
Outdated
| object_link.short_description = 'object' | ||
|
|
||
| def queryset(self, request): | ||
| return super(LogEntryAdmin, self).queryset(request).prefetch_related('content_type') |
There was a problem hiding this comment.
Just super() now we are python 3.
judge/admin/interface.py
Outdated
| link = obj.object_repr | ||
| return link | ||
| object_link.admin_order_field = 'object_repr' | ||
| object_link.short_description = 'object' |
There was a problem hiding this comment.
This should be marked for i18n.
judge/admin/interface.py
Outdated
| return False | ||
|
|
||
| def has_change_permission(self, request, obj=None): | ||
| return request.user.is_superuser |
There was a problem hiding this comment.
I don't know if superusers should be able to forge records...
quantum5
approved these changes
Apr 18, 2019
quantum5
reviewed
Apr 18, 2019
| readonly_fields = ('user', 'content_type', 'object_id', 'object_repr', 'action_flag', 'change_message') | ||
| list_display = ('__str__', 'action_time', 'user', 'content_type', 'object_link') | ||
| search_fields = ('object_repr', 'change_message') | ||
| list_filter = ('user', 'content_type') |
There was a problem hiding this comment.
Uhhhh... this lists all the users on the site. That's... excessive.
malbareda
pushed a commit
to malbareda/JOEL-web
that referenced
this pull request
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #755.