Admin users unable to customise template

[dsisu]

Please complete the following fields as applicable:

Expected behaviour:

Able to edit customisable funder templates

Actual behaviour:

If you try to add a section, for example, it appears that all works correctly but when you come back to view the template later, all the edits are missing.

Steps to reproduce:
Try to customise BBSRC template, for example. All funder templates at UoE appear to have not been customised so assign yourself to University of Manchester and compare behaviour in BBSRC template vs AHRC template.

The issue appears to be relating to templates that haven't been customised before. To identify these at a glance, check whether the status is set to 'not customised'. If you don't want to rely on the 'status' info only (which has been unrealiable on one occasion), also check the 'actions' available, which should include 'customise'.

I reported that Kerry Miller at UoE tried to customise BBSRC template by adding sample answers and got the same results. It's probably down to the fact that users are not seeing the latest version of the template.

[dsisu]

This needs to be resolved by the 17th of April at the latest.

[stephaniesimms]

I tested on roadmap stage and dmptool and confirmed that published customizations/annotations do not appear to end users when they select the customized template to create a new plan. the bug might be associated with the larger template versioning issues.

to clarify the bug report: As an admin I can customize a template by clicking to create/add an example answer or guidance and then publish my customizations. these appear as expected in the admin templates area. but when I create a plan using one of these templates I don't see any of the customizations in the write plan area.

[briri]

I tried this on roadmap-stg by logging in as myself (super admin affiliated with UCOP) and selected to customize the DOD template (no previous customizations for that one). I added an example answer, "This is an example answer" and some guidance, "This is my guidance" to the first question, saved the changes and then went back and published the customized template.

I then logged in as a separate user also affiliated with UCOP and created a plan (research org = UCOP and funder = DOD). I went to the Write Plan tab and see my custom guidance but do not see my example answer.

So I'm seeing different behavior. It selected the correct customized version of the template. Its just not displaying example answers properly (it looks like the question text was used instead for some reason. you can see it duplicated in the screenshot).

Also note that the 1st tab in the Guidance section says 'UCOP' because that was the org that customized the original template but we may want it to show 'DOD'. The first 'Guidance' section on the right was entered into the base DOD template and the 2nd is mine. The second guidance section should probably read 'Additional UCOP guidance' or something like that if we update the logic to show 'DOD' as the tab name

[stephaniesimms]

after more testing on roadmap stage, I can confirm most of what @briri observed for the DOD template. As a Pitt admin, I customized the NIH-GDS template with guidance text and example answers, then created a plan with it. I did the same thing on dmptool stage. Everything works as expected from the admin side with creating and publishing customizations.

The screenshot below shows the following errors with how the customizations are displayed (or not) when I create a plan with the customized template:

• the question text is okay for my plan. @briri has duplicate question text for DOD Q1 above because of duplicate template data. I updated the template and now it's fine.
• The first tab for the NIH-GDS funder guidance that is attached to the template is renamed "Pitt." This tab should say "NIH-GDS"
• the Pitt guidance text customization appears in this tab with the same generic "Guidance" label. It should say "Pitt Guidance" if it is supposed to appear here. Otherwise it should be under the second tab with the correct "Pitt" label that also contains generic themed guidance.
• example answers do not appear at all. they should be displayed below the text editor.
• when I return to the Templates page and click "Edit customization" to view it, the customization status changes to "Unpublished" and it no longer appears on the template when I create a new plan. this last issue seems to be related to versioning. desired behavior is to only create a new version if user makes a change to the customization.
• I added related bug Reload Customizable templates tab after publishing #1338 "reload customization tab after clicking publish" to the board - it would be good to address this at the same time if easy.

[briri]

Example answer isn't picking up customization (just the question level):

roadmap/app/views/answers/_new_edit.html.erb

Line 67 in 67edbda

<% annotation = question.first_example_answer %>

related to #1342, #1343, #1344 and #1345 (created during 4/4/18 dev discussion)

[stephaniesimms]

this is the original/global issue. all the pieces are fixed in other issues and the functionality is workign as expected now. closing.