@xsrust xsrust released this Oct 23, 2018 · 1 commit to master since this release

Assets 2

Upgrade Process

This release introduces so major changes to the way we ensure our data is valid. The upgrade process is detailed on the wiki: https://github.com/DMPRoadmap/roadmap/wiki/Upgrading-from-v1.x-to-2.0.0

Changes

OrgAdmins

  • Template Sections can now be re-organised via drag-and-drop
  • Changed message text for flash notice when removing User permissions (#1880)
  • Added button to download list of CSV users (#1754)
  • Added status for total org users and plans (#1760)

Researchers

  • Comments are now visible by default, without having to click "Show" (#1873)
  • Updated text labels on form buttons for better clarity (#1781)
  • Removed multi-select box as an answer format (#1771)

Developers

  • Normalised asset compilation. Now you can use rake assets:precompile to build JS and CSS assets.
  • Consolodated and simplified JS code.
    This commit removes duplication in the JS code, making it simpler and easier to manage (#1752)
  • Added new System-wide configuration for plan readability. Developers can now set whether org admins may view each plan within their org or not, via branding.yml
  • Added Bullet gem to identify sub-optimal database queries in development mode #1675
  • Replaced MiniTest suite with RSpec (#1664)
  • Installed Capybara and Selenium for integration tests #1668
  • Removed unused methods from models #1572
  • Add additional validations to ActiveRecord models
    NOTE: This will require you to run some rake tasks to ensure your own data is valid. Please view this README for more information (#1572)
  • Installed Annotate gem for automated comments in Gemfile and models (#1672)
  • Renamed deprecated deliver methods to deliver_now (#1695)
  • Replaced fixtures with FactoryBot factories for tests (#1651)
  • Added Faker gem for better factory test data (#1666)
  • Added Shoulda gem for cleaner tests
  • Removed attr_accessible from models and added strong params to controllers (#100)
  • The BetterSpecs.org is now our standard guide for writing tests (#1665)
  • Replaced instances of raw method with sanitize for safer HTML escaping (#532)
  • Removed unused accessibility link from layout footer (#1734)
  • Removed number field from sections form (#1371)

Bug fixes

  • Fixed bug preventing users from adding new questions (#1723)
  • Fixed CSS bug causing page footer to overlap when page content is long (#1300)
  • Fixed bug on plan downloads that was ignoring the user-defined configurations (#1730)
  • Fixed bug when downloading a public or org DMP (#1841, #1785)
  • Fixed bug on user org change that ensures other_organization column is reset (#1736)
  • Fixed bug preventing super-admin from switching orgs (#1835)
  • Fixed the layout of annotations within questions (#1833)
  • Fixed bug preventing users from requesting feedback on a plan (#1845)
  • Fixed bug affecting the display order of sections within templates (#1371)
  • Fixed instances where TinyMCE would not load when added by Ajax (#1777)
  • Fixed bug showing the wrong value for "Not customised" templates (#1815)
  • Fixed bug showing guidance with multiple themes multiple times (#1755)
  • Fixed bug showing incorrect display name for guidance subgroups (#1409)
  • Fixed bug causing org dropdown on sign-up form to be empty when is_other is false (#1809)
  • Fixed bug breaking autosave on TinyMCE forms (#1878)
  • Fixed bug preventing org admin from turning on feedback (#1877)

@briri briri released this Jul 19, 2018 · 508 commits to master since this release

Assets 2

Researchers

  • When a user shares a plan with a colleague the email will now display the user's name #1587

Org Admins

  • Option based template questions (e.g. select box, radio buttons, etc.) now allow for an unlimited number of choices #1640
  • You can now associate guidance with multiple themes again #1742
  • Updates to the 'Request Expert Feedback' functionality:
    • Improved tooltip language to help clarify the purpose of items on the Admin -> Organization details -> Request Feedback tab #1722
    • The system now displays the 'Request Feedback Message' to your users on-screen instead of sending them an email #1163
    • Updated the 'Request Feedback complete' email to include clearer instructions on how the user can find your comments and a direct link to the appropriate page #1431 & #1492

Bug Fixes

  • Addressed an issue that some users were encountering when trying to change their email address #1714
  • Addressed an issue that caused Shibboleth IdP information to be lost when editing an Org's request feedback options #1732
  • Fixed an issue with Guidance page form validations #1629
  • Users can now click the 'Show password' checkbox on the create account form #1702
  • Theme selections are no longer deleted when an admin adds annotations/customizations to a question #1684
  • Fixed issue preventing users from submitting the create account form #1680

Accessibility

  • Groups of Check boxes and Radio buttons are now properly nested within <fieldset> tags #1448

General Improvements

  • Decreased vertical white space between themes on the Guidance and Question editing sections #1708
  • Updated Tinymce calls so that they all us a standard set of toolbar options #1632

@xsrust xsrust released this Jun 22, 2018 · 553 commits to master since this release

Assets 2

This release is a minor patch to v1.1.2. Please refer to the v1.1.2 release notes for important information on recent changes and the need to run rake upgrade:v1_1_2 and manually update data.

  • Added an additional string to translation files
  • Added in missing fr_FR and pt_BR translation files for devise, contact_us and bootstrap gems

@briri briri released this Jun 19, 2018 · 557 commits to master since this release

Assets 2

Note that you will need to run rake upgrade:v1_1_2 task to update your database (see the database changes list below for details

Bug fixes

  • Tinymce editors on Template edit page now have bulleted lists and table options again #1594
  • Improvements to the consistency of the Organisation selection boxes #1589
  • Labels on the Create Plan page updated to make the requirements clearer for the user #1479
  • The system will no longer email all admins when a user requests feedback #1217
  • Current tab is now properly highlighted #1603
  • Fixed default sort on Public Templates page #1333
  • The 'Show full list' link on the shibboleth org selection page was fixed #1617
  • Guidance can now have only one associated theme #1212

Accessibility updates

  • 'Skip to main content' link added for screen readers #1442
  • Pages now have unique titles #1441
  • All form input elements now have labels #1445
  • All buttons now provide a visual cue when they have focus #1443
  • Properly grouped PI and Data Contact elements on the Project details page #1454

Translations

  • New translatable:find rake task to replace gettext:find. This new task gathers all translatable strings from the code and updates the POT/PO files accordingly. #1339
    • #, fuzzy means that the string is new and needs to be translated
    • #msgid means that the string is no longer in the code (obsolete) and can be deleted
  • New translations for Française (France) - thanks to the DMPOPIDoR team
  • New translations for Português (Brasil) - thanks to The University of Campinas

Database changes

  • The orgs.contact_email is now required. This will add the helpdesk email defined in your branding.yml file to any orgs whose contact_email is blank. The task will provide feedback on which records have been updated.
  • Guidance can now only have one associated theme. The task will notify your of which guidances have multiple theme associations. You will need to manually update those records to select the most appropriate theme.
  • Removes the email notification preference for receiving emails when a user requests feedback. Only the org's contact_email is notified now when a user requests feedback.

The translation files are now complete and contain all of the translatable text within the codebase. To see a list of these changes, please refer to the comparison page, click on the 'Files changed' tab and then scroll down to the config/locale/app.pot file . The list of changed translations should be smaller in future releases now that we have a complete set.

@briri briri released this May 31, 2018 · 612 commits to master since this release

Assets 2

Added a Privacy statement for GDPR

  • GDPR privacy statement added to footer #1556

Bug fixes

  • Fixed format of links in DOCX downloads #1185
  • Fixed bug that allowed users to edit historical template information #1554
  • Removed Copyright statement from downloaded plan coversheet when the plan is not public #1549
  • Fixed bug with updating email notification preferences for non super-admin users #1514
  • Fixed bug with Plan Overview page for multi-phase templates #1548

@briri briri released this May 23, 2018 · 627 commits to master since this release

Assets 2

Summary

  • Fixed issues with when and where templates are versioned
  • Fixed numerous usability issues on the Templates and Template editing pages
  • Added a Global Notification system (courtesy of the DMP OPIDoR team)
  • Upgraded to the latest versions of Ruby and Rails

This upgrade will require you to:

  • Install Ruby 2.4.4
  • Run rake upgrade:remove_duplicated_template_versions to remove any duplicated versions created by the old codebase
  • Run rake db:migrate to update your templates table, drop an unused table, and add the tables needed for the notification system
  • Run bundle install
  • Run npm install (from the lib/assets/ directory)
  • Run npm run bundle [-- -p (if in production)] (from the lib/assets/ directory)

Details

  • Global Notification system

    • Super admins can now define system messages that are displayed to users when they log into the site
    • Messages can be defined as dismissable, and have a begin and end date
    • Example uses: System maintenance announcements, Funder template changes, etc.
    • New DB tables added to support the notifications: notifications and notification_ackowledgements
  • Upgrade to Ruby 2.4.4 and Rails 4.2.10

    • Upgrade Ruby 2.2.2 -> 2.4.4
    • Upgrade Rails 4.2.7 -> 4.2.10
    • Updated Gemfile to remove version specifications for most gems
    • Updated Gemfile to remove unused gems (rollify, yard, red-carpet, swagger-docs, friendly_id, yaml_db, minitest-rails-capybara, administrate)
    • Dropped unused friendly_id_slugs table that was used by one of those gems
    • Updated all NPM JS dependencies
    • Updated various tests and files to correct deprecation warning messages
  • Template pages refactor

    • Complete refactor of all Template/Phase/Section/Question/Annotation files models, controllers, views, JS
    • Renamed columns in the templates table (migrated->archived, dmptemplate_id->family_id)
    • Removed dirty flag from templates table
    • Extracted and rewrote all of the scopes from models/template.rb to models/scopes/template_scope.rb
    • Moved all template/phase/section/question/question_option controllers to the org_admin namespace and updated routes accordingly
    • Added a new controllers/concerns/versionable.rb concern to aid controllers with determining what changes create a new template version
    • All versioning and customization logic moved from controllers to the models
    • Updated Template edit page so that sections and questions load on demand via AJAX rather than on inital page load
    • Refactored all related JS
    • Added unit and functional tests for all refactored objects
    • Updated test_helper.rb to act as a factory for creating test objects

@briri briri released this Apr 25, 2018 · 650 commits to master since this release

Assets 2

Researchers

  • The contact us form no longer throws an 'Invalid Captcha' error when you try to submit the form when logged in. #1394
  • Plans on the My Dashboard page are now sorted by the date they were last updated (descending) #1395

Org Admins

  • Addressed some issue with displaying usage statistics for some users #1410
  • Editing the default template no longer results in its disappearance from the customizable templates table and it remains available to users creating a new plan #1415

Developers

  • Fixed an issue with OmniAuth redirects when working from localhost #1397

@briri briri released this Apr 17, 2018 · 657 commits to master since this release

Assets 2

Org Admins

  • Fixes an issue with uploading logos for an organisation #1357
  • Fixes an issue with the status of funder template customizations #1363

Developers

  • Contact us form submission will now fail if the Recaptcha checkbox has not been checked #501

@briri briri released this Apr 6, 2018 · 667 commits to master since this release

Assets 2

Patches for issues reported when trying to customize templates (#1318):

  • Customizable Templates status column now shows proper 'Unpublished changes' status #1345
  • Funder template default visibility is 'Public' now #1342
  • The Customizable Templates tab stays in focus after publishing/unpublishing a template customization #1338
  • Customized example answers now appear when editing a plan #1344
  • Guidances tab on the write plan page now shows the Org abbreviation before each guidance section for customized templates #1343

@jollopre jollopre released this Mar 29, 2018 · 688 commits to master since this release

Assets 2
  • Bugfix to prevent paginable success handler to be executed when it should not. This fix solves the problem of ending up with a blank view when an action in any row from a paginable table is triggered.