Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static scoreboard links should be relative #2070

Open
troy2914 opened this issue May 31, 2023 · 3 comments
Open

Static scoreboard links should be relative #2070

troy2914 opened this issue May 31, 2023 · 3 comments
Assignees

Comments

@troy2914
Copy link

seen using 8.3.0DEV/471813069
the
/public?static=1
scoreboard emits bits like this:

/favicon.ico
/images/*
/css/*
/style_domjudge.css
/markdown-preview

all those items should be relative (and any others I missed to list). This allows one to use the static website under a subdir, without having to tweak it.

@nickygerritsen
Copy link
Member

I don’t think we can fix this easily. It might be our zip does do this though, so I will check if that’s the case and next year we use that logic

@eldering eldering changed the title static scoreboard links should be relative Static scoreboard links should be relative Jun 2, 2023
@vmcj
Copy link
Member

vmcj commented Feb 25, 2024

I don’t think we can fix this easily. It might be our zip does do this though, so I will check if that’s the case and next year we use that logic

According to https://symfony.com/doc/current/routing.html we can pass a constant (UrlGeneratorInterface::RELATIVE_PATH) for this, would that give problems @nickygerritsen ?

@nickygerritsen
Copy link
Member

We can test this. I’m not sure

@vmcj vmcj self-assigned this Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants