From c8c0f1f80b1686fbb0843b65b3b8ab76be8c332f Mon Sep 17 00:00:00 2001 From: Michael Vasseur Date: Fri, 22 Nov 2024 17:44:34 +0100 Subject: [PATCH] Remove fixme but list the outstanding bugs The original bug was fixed but while testing for another PR it shows that getopt doesn't parse options in the normal POSIX expected way. --- judge/judgedaemon.main.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/judge/judgedaemon.main.php b/judge/judgedaemon.main.php index ae63c1dfd4..ae1b42e074 100644 --- a/judge/judgedaemon.main.php +++ b/judge/judgedaemon.main.php @@ -488,7 +488,8 @@ function fetch_executable_internal( } $options = getopt("dv:n:hVe:j:t:", ["diskspace-error"]); -// FIXME: getopt doesn't return FALSE on parse failure as documented! +// We can't fully trust the output of getopt, it has outstanding bugs: +// https://bugs.php.net/search.php?cmd=display&search_for=getopt&x=0&y=0 if ($options===false) { echo "Error: parsing options failed.\n"; usage();