fix: stabilize prototype backend and Unity smoke#160
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0522a1aeb0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
| action: "stop", | ||
| reason: "request_context_canceled", | ||
| confidence: 0.1, | ||
| source: "fallback", | ||
| source_reason: "nakama_context_canceled" |
There was a problem hiding this comment.
Return an allowed action for canceled decision RPC
rpcAgentDecide now returns a hardcoded fallback action: "stop" when context is canceled, but this bypasses the normal allowed-intent validation path. In player-chat turns, BuildDecisionRequest sends allowed = ["say"] (see PrototypeAgentBrain), so this response can be out-of-contract and causes the chat loop to treat the turn as handled and clear pending chat without a reply. Please derive the fallback action from request.allowed (or keep it as an error) so canceled requests cannot emit disallowed intents.
Useful? React with 👍 / 👎.
| } | ||
| else { | ||
| $packageManagerMatches = @($logTail | Select-String -Pattern 'The "path" argument must be of type string|Failed to resolve packages|Package Manager' -SimpleMatch:$false) | ||
| $compileMatches = @($logTail | Select-String -Pattern "Assets\\.*\\.cs\\(.*\\): error CS|Compilation failed|Compiler errors") |
There was a problem hiding this comment.
Fix compile-error regex to detect Unity compiler failures
The compile-error pattern uses Assets\\.*\\.cs..., which regex-parses as Assets\.*\.cs and matches only repeated dots after Assets\, not real paths like Assets\Scripts\Foo.cs(...). As a result, check-local-health.ps1 can miss actual error CS... lines in Editor.log and incorrectly report Unity Compile as OK, reducing the reliability of the local smoke gate.
Useful? React with 👍 / 👎.
0522a1a to
03e5eac
Compare
|
Codex (@codex) review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Summary
33and34design numbers.Verification
npm.cmd run buildinbackend/nakamanpm.cmd testinbackend/nakamagit diff --checkandgit diff --cached --checktools/windows/*.ps1andtools/launch-local-second-client.ps1request_recompile+wait_for_compilation: no compile errorsNotes
--no-gpg-signbecause the local SSH signing agent refused the signing operation.