Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support mongoose ^8.0.0 #47

Merged
merged 1 commit into from
Mar 12, 2024
Merged

support mongoose ^8.0.0 #47

merged 1 commit into from
Mar 12, 2024

Conversation

simonecorsi
Copy link
Contributor

Hi, I'm successfully using this package in my mongoose ^8 projects and we have to use --legacy-peer-deps everytime, can we update this? :)

@coveralls
Copy link

Coverage Status

coverage: 98.534%. remained the same
when pulling 3270c13 on simonecorsi:master
into 6c396f2 on DScheglov:master.

@DScheglov DScheglov merged commit 983bddd into DScheglov:master Mar 12, 2024
21 checks passed
@DScheglov
Copy link
Owner

Hi, @simonecorsi

thank you for PR -- I've merged it, but it seems tests fail with mongoose@8:
https://github.com/DScheglov/mongoose-schema-jsonschema/actions/runs/8247422956/job/22555515343

So, I'm going to fix this in the lib code, then I will publish a new version.

@simonecorsi
Copy link
Contributor Author

Hi, @simonecorsi

thank you for PR -- I've merged it, but it seems tests fail with mongoose@8: https://github.com/DScheglov/mongoose-schema-jsonschema/actions/runs/8247422956/job/22555515343

So, I'm going to fix this in the lib code, then I will publish a new version.

Ok, no hurry thank you! Let me know if there is something we can do to help!

@DScheglov
Copy link
Owner

@simonecorsi

it was quite simple fix.
Now you can use mongoose-schema-jsonschema@2.2.0

@simonecorsi
Copy link
Contributor Author

@DScheglov Thank you 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants