Permalink
Browse files

Tidy up some warnings and hints

  • Loading branch information...
mwoodiupui committed Jan 31, 2014
1 parent bdb1b82 commit bd3d5eccf6721a3086e6b9ca7b261260923c4700
Showing with 5 additions and 4 deletions.
  1. +5 −4 dspace-api/src/main/java/org/dspace/statistics/util/StatisticsImporter.java
@@ -29,7 +29,7 @@
import com.maxmind.geoip.Location;
/**
- * Class to load intermediate statistics files (produced from log files by <code>ClassicDSpaceLogConverter</code>) into Solr
+ * Class to load intermediate statistics files (produced from log files by {@link ClassicDSpaceLogConverter}) into Solr.
*
* @see ClassicDSpaceLogConverter
*
@@ -40,7 +40,7 @@
private static final Logger log = Logger.getLogger(StatisticsImporter.class);
/** Date format (for solr) */
- private static SimpleDateFormat dateFormat = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss");
+ private static final SimpleDateFormat dateFormat = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss");
/** Solr server connection */
private static HttpSolrServer solr;
@@ -67,7 +67,7 @@
private List<Integer> localBitstreams;
/** Whether or not to replace item IDs with local values (for testing) */
- private boolean useLocal;
+ private final boolean useLocal;
/**
* Constructor. Optionally loads local data to replace foreign data
@@ -495,6 +495,7 @@ public static void main(String[] args) throws Exception
File dir = sample.getParentFile();
FilenameFilter filter = new FilenameFilter()
{
+ @Override
public boolean accept(File dir, String name)
{
return name.startsWith(sample.getName());
@@ -522,7 +523,7 @@ public boolean accept(File dir, String name)
*/
static class DNSCache<K,V> extends LinkedHashMap<K,V>
{
- private int maxCapacity;
+ private final int maxCapacity;
public DNSCache(int initialCapacity, float loadFactor, int maxCapacity)
{

0 comments on commit bd3d5ec

Please sign in to comment.