Bring dspace-oai Spring configuration / service handling in line with other modules #8432
Labels
code task
Code cleanup task
interface: OAI-PMH
Related to the OAI-PMH interface (dspace-oai module)
needs discussion
Ticket or PR needs discussion before it can be moved forward.
new feature
While trying to find a good way to use a mock OAI Solr core for integration testing, I realised how differently the dspace-oai module uses spring compared to other modules. Something that seemed like it should be relatively simple (define a mock OAI solr core/service in solr-services.xml which will be autowired in place of the usual http service) ended up getting quite tricky to pull apart and plan.
See:
org.dspace.app.xoai.BasicConfiguration
, the resolvers, and usage in other classes.This issue might be closely related to #8112 (dependency injection issues)
cc: @mwoodiupui
Solutions?
I wanted to open this ticket to discuss possible solutions... I think a refactor to bring dspace-oai closer to how the rest of the codebase works will make things easier for developers in general.
The text was updated successfully, but these errors were encountered: